Repository navigation
Allow just "Magtag"; don't require "MagTag with ESP32S2" - #76
Merged
Merged
Conversation
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 19, 2026
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.3.13 from 5.3.12: > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#130 from dhalbert/cpb-detection Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.8.4 from 4.8.3: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#114 from dhalbert/ignore-tls-accept-errors Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 3.2.13 from 3.2.12: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#107 from dhalbert/uname-machine Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 4.0.13 from 4.0.12: > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#76 from dhalbert/magtag-name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was making sure the chip name matches on
os.uname().machinewere case-insensitive; see adafruit/Adafruit_CircuitPython_MatrixPortal#107 for an example.I could do a case-insensitive match on
MagTag with ESP32S2, but there is no other MagTag now, and one would hope that one with a different chip would work also. So let's just match onMagTag.