Skip to content

Allow just "Magtag"; don't require "MagTag with ESP32S2" - #76

Merged
FoamyGuy merged 1 commit into
adafruit:mainfrom
dhalbert:magtag-name
Nov 18, 2026
Merged

FoamyGuy merged 1 commit into
adafruit:mainfrom
dhalbert:magtag-name

Conversation

@dhalbert

Copy link
Copy Markdown
Contributor

I was making sure the chip name matches on os.uname().machine were case-insensitive; see adafruit/Adafruit_CircuitPython_MatrixPortal#107 for an example.

I could do a case-insensitive match on MagTag with ESP32S2, but there is no other MagTag now, and one would hope that one with a different chip would work also. So let's just match on MagTag.

@dhalbert
dhalbert requested a review from FoamyGuy November 18, 2026 16:50

@FoamyGuy FoamyGuy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@FoamyGuy
FoamyGuy merged commit e4e1a3e into adafruit:main Nov 18, 2026
1 check passed
@dhalbert
dhalbert deleted the magtag-name branch November 18, 2026 17:09
adafruit-adabot pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 19, 2026
Updating https://github.com/adafruit/Adafruit_CircuitPython_CircuitPlayground to 5.3.13 from 5.3.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_CircuitPlayground#130 from dhalbert/cpb-detection

Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.8.4 from 4.8.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#114 from dhalbert/ignore-tls-accept-errors

Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 3.2.13 from 3.2.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#107 from dhalbert/uname-machine

Updating https://github.com/adafruit/Adafruit_CircuitPython_PyBadger to 4.0.13 from 4.0.12:
  > Merge pull request adafruit/Adafruit_CircuitPython_PyBadger#76 from dhalbert/magtag-name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants