Repository navigation
fix(stream-transform): honor falsy params in the sync API - #528
Merged
Merged
Conversation
wdavidw
reviewed
Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synchronous API rejects a two-argument handler when
paramsis0,false, or an empty string, even though those values are valid parameters in the streaming API. Match the streaming null/undefined check when validating handler arity.Regression tests cover all three values and confirm that null/undefined still reject callback handlers. Rebuilt the distributed bundles.
Validation:
npm test --workspace stream-transform(86 passing),npm run lint:check --workspace stream-transform, andnpm run build --workspace stream-transform.