Repository navigation
Conversation
wdavidw
reviewed
Oct 11, 2026
wdavidw
reviewed
Oct 11, 2026
Member
|
@xiehuanyi why did you close the PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ColumnsFunctionrequires a string result even though the generator supports strings, numbers and null. Match the declaration to those supported return values and regenerate the distributed declarations.Convert the existing
options.columns.jssuite to TypeScript, retaining its string/null/number and invalid-return runtime coverage. This replaces the redundant added API test. The converted suite also exercises the existingGenerator.end()method, so its missingend(): voiddeclaration is included.Validation: restoring the previous
ColumnsFunctionreturn type makes the existing converted column test fail to typecheck.npm test --workspace csv-generatepasses typechecking and 79 tests (2 existing pending Web Stream tests);npm run lint:check --workspace csv-generatepasses with the 2 existing pending-test warnings;npm run build --workspace csv-generatepasses.