Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synchronous generator enters an endless loop when a column returns an unsupported value: the shared generator calls
destroy(error), but the sync loop never receives that asynchronous stream error or a completion signal. Surface those validation errors synchronously in the sync adapter.A standalone reproduction with
columns: [() => true]timed out after two seconds before this change. Regression tests now verify immediate errors for unsupported values, errors after a valid record, and preservation of exceptions thrown by column functions. Rebuilt distributed bundles.Validation:
npm test --workspace csv-generate(84 passing; 2 existing pending),npm run lint:check --workspace csv-generate(no errors; 2 existing pending-test warnings), andnpm run build --workspace csv-generate.