Skip to content

fix(csv-stringify): preserve caller column definitions - #531

Open
xiehuanyi wants to merge 2 commits into
adaltas:masterfrom
xiehuanyi:fix/stringify-immutable-column-definitions
Open

xiehuanyi wants to merge 2 commits into
adaltas:masterfrom
xiehuanyi:fix/stringify-immutable-column-definitions

Conversation

@xiehuanyi

@xiehuanyi xiehuanyi commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Normalizing a column without header writes that field into the caller’s object. A frozen column therefore throws, and changing the key on a reused definition can keep the previous automatically inserted header.

Copy column definitions during normalization and apply the default header to the copy. Preserve the explicit key as well, including inherited, non-enumerable and getter-backed keys accepted by the existing API.

Validation:

  • Regression cases cover frozen configuration, reuse after a key change, and three structural key definitions.
  • Full csv-stringify suite: 237 passed, 1 existing pending test; TypeScript passed.
  • Package build passed; full package lint passed with its existing pending-test warning.

Prepared with AI assistance. Source changes only; generated bundles were validated locally.

Copilot AI balanced review requested due to automatic review settings October 11, 2026 21:31

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants