Repository navigation
fix(compliance): decouple fixture provenance version - #2962
Merged
Merged
Conversation
bokelley
marked this pull request as ready for review
September 18, 2026 11:04
There was a problem hiding this comment.
Ladon verdict: Approve
Approve
Decouples immutable canonical storyboard fixtures from the moving ADCP_VERSION pin by removing the protocol_version === ADCP_VERSION guard in scripts/sync-canonical-storyboard-fixtures.ts, while preserving every integrity check (source_tag, source_commit, bundle/file hashes, byte-exact verification). Ships a correctly scoped patch changeset and a hermetic regression test.
Checked:
- Changeset present and correctly scoped (patch) for the build-affecting
scripts/**change — satisfies changeset-vs-wire-impact. - No witness-not-translator violations: no fabricated fields or re-shaping; integrity checks retained.
- No transport-client concerns (no
src/lib/protocols/orsrc/lib/client/changes). - New regression test covers the added behavior.
No blocking or Medium findings. high_risk false, gated_paths false, no no-auto-approve team match, no prior decision. Note: review_decision is REVIEW_REQUIRED, but that only forces escalation when gated_paths is true (row 2) — it is false here, so the PR falls through to row 9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the AdCP 3.2.0-rc.4 release candidate validation in adcontextprotocol/adcp#7508.
Canonical principal and reporting-core fixtures are independently immutable artifacts from AdCP 3.2.0-rc.3. Their own manifest already pins the exact source tag, commit, bundle digest, file SHA-256 values, Git blob IDs, paths, and byte sizes. Requiring that fixture source version to equal the SDK schema target creates a release deadlock: a candidate SDK build cannot validate rc.4 until an rc.4 fixture tag exists, but the protocol tag cannot land until that candidate build passes.
This removes only the equality check against ADCP_VERSION. Every provenance and byte-integrity check remains fail-closed.
Qualification on the exact published head:
Includes a patch Changeset.