Repository navigation
Conversation
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — clean DR-0033 minor-release fix with no blocking or medium findings.
Checked:
- Witness-not-translator: The 3-line change in
src/lib/v2/projection/creative-delivery.tsadds an earlyreturn nextso proven AdCP 3.1 package requests preserveformat_kind/paramswhen no single legacy mapping exists, mirroring the existing format_option_refs preservation (L1766-1775). No fabrication or re-shaping — it preserves exactly what upstream sent. - DR-0033 pathway: Explicit legacy mapping still wins; ambiguous explicit format_ids still refuse (legacyRefs.length===0 guard); 3.0/unproven peers still refuse. Refused-for-previous-minor pathway is respected and tested.
- Changeset-vs-wire-impact: Patch changeset present and defensible for this preservation fix (no removed/renamed export, no required-param flip, no dropped enum).
- Tests: Nine targeted regressions cover both public clients, both pins, create vs update, and the 3.1 package schema.
- Docs: Updated.
No Medium-or-worse findings. No gated paths, no high-risk files, no no-auto-approve team match. gated_paths: false, so the REVIEW_REQUIRED status does not block. Falls through to decision table row 9 → approve.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve format_kind and params on proven AdCP 3.1 create_media_buy packages and update_media_buy new_packages when no single legacy mapping exists. Keep explicit mapping precedence and refusal for 3.0, unproven peers, ambiguous explicit references and existing-package updates.
Validation: 112 packaged selector, creative-delivery and projection tests pass on Node 24 with the official runner. All 40 selector tests also pass on Node 20, including both public clients and the bundled 3.1 package schema. Nine new regressions fail before the fix. Build, typecheck and the patch changeset check pass. The complete SDK suite remains unverified locally; an earlier full-suite attempt hit an unchanged type-fixture timeout.
Hosted CI: Generated, Docs & Formatting fails because the live registry sync changes schemas/registry/registry.yaml and src/lib/registry/types.generated.ts. Both files are unchanged by this PR. The official sync generator reproduces the drift from pristine main inputs at ccfc06c.
Fixes #3671.