Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/canonical-format-validate-input-required-tools.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"adcontextprotocol": patch
---

`canonical_format_validate_input` no longer lists `comply_test_controller` in `required_tools`. The storyboard runner's per-storyboard gate admits a storyboard when any listed tool is present, so any agent exposing the (universal) test controller was selected and then failed all 17 steps on the missing `validate_input`. Agents without `validate_input` now receive a coverage-gap skip; agents implementing it run unchanged. Same shape as #6774 (fixes #7404, bug 1).
4 changes: 2 additions & 2 deletions .github/workflows/training-agent-storyboards.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ jobs:
- surface: current
tenant: governance
min_clean_storyboards: 47
min_passing_steps: 161
min_passing_steps: 160
- surface: current
tenant: creative
min_clean_storyboards: 49
Expand All @@ -92,7 +92,7 @@ jobs:
- surface: current
tenant: brand
min_clean_storyboards: 45
min_passing_steps: 116
min_passing_steps: 115
- surface: current
tenant: si
min_clean_storyboards: 42
Expand Down
4 changes: 2 additions & 2 deletions scripts/run-storyboards-matrix.sh
Original file line number Diff line number Diff line change
Expand Up @@ -269,10 +269,10 @@ else
# clean-result-row and passing-step regression floors.
"signals:45:80"
"sales:133:632"
"governance:47:161"
"governance:47:160"
"creative:49:209"
"creative-builder:50:184"
"brand:45:116"
"brand:45:115"
"si:42:50"
)
fi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ track: creative
introduced_in: "3.1"
required_tools:
- validate_input
- comply_test_controller

requires:
- controller
Expand Down
10 changes: 8 additions & 2 deletions tests/run-storyboards-sharding.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -300,13 +300,19 @@ test('creative-builder uses bounded isolated children in local and CI matrices',
test('current training-agent floors are ratcheted and mirrored by local and CI runners', () => {
const workflow = fs.readFileSync(STORYBOARD_WORKFLOW, 'utf8');
const matrixRunner = fs.readFileSync(MATRIX_RUNNER, 'utf8');
// governance and brand dropped one passing step each when
// canonical_format_validate_input stopped listing comply_test_controller in
// required_tools: both tenants expose the controller but not validate_input,
// so the storyboard is no longer selected for them and the single step it
// contributed is gone. Deliberate de-ratchet, not a regression — the
// clean-storyboard floors are untouched.
const baselines = [
['signals', 45, 80],
['sales', 133, 632],
['governance', 47, 161],
['governance', 47, 160],
['creative', 49, 209],
['creative-builder', 50, 184],
['brand', 45, 116],
['brand', 45, 115],
['si', 42, 50],
];

Expand Down
Loading