Repository navigation
Conversation
Contributor
Author
|
Closing as superseded by #7514, which provides the broader deterministic PostgreSQL barrier fix for this recurring ledger-test race. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMMIT, when its target-plan row lock is definitively releasedThis changes only the integration test. Production timeout, retry, fail-closed, ledger, and migration behavior are unchanged.
Failure evidence
The unchanged baseline test failed on PRs #7446, #7463, and #7475 when the unsynchronized recovery race returned
persistence_uncertain. Local baseline stress reproduced the line-414 failure in 15 of 16 concurrent runs.Verification
Exact reviewed head:
fd82d7835dbc9ed57ccfc7626f248ff2212c9235.npm run typecheck: passedgit diff --check: passedThe complete 36-test PostgreSQL file was also exercised locally. The modified test passed, but the VM consistently hit a separate unchanged timeout race in the preceding
runs provider-intent recovery independently of a concurrent standalone recoverytest at line 372 (35/36 passed). That test fails before the modified case and was not broadened into this narrowly scoped fix. GitHub's clean PostgreSQL integration matrix passed all four shards at the exact head above.Remaining gate
Human maintainer review is requested from
@adcontextprotocol/maintainers. Keep this PR Draft with auto-merge disabled; do not merge as part of this handoff.Open workspace in Conductor