Repository navigation
Conversation
bokelley
force-pushed
the
conductor/addie-explicit-organization
branch
2 times, most recently
from
September 17, 2026 18:40
2b42f50 to
9941963
Compare
Base automatically changed from
conductor/addie-explicit-organization
to
main
September 17, 2026 18:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authenticated native sealed-session bearers currently reach organization resolution after middleware authentication and are rejected as invalid organization-bearing JWT/API-key credentials. This narrow follow-up records authenticated sealed-bearer transport provenance in middleware and lets the organization helper consume that exact snapshot only when the presented token and snapshot still match. Existing explicit organization selectors continue through exact-credential direct membership or valid explicit credential grants.
No implicit organization fallback is restored for zero, one, or many organizations. Primary-org, sole-org, canonical-sibling, and email authority are not inferred. Cookie behavior and the deliberate Addie sole-org behavior in member-context are unchanged. Scope is limited to the two authentication files and one regression suite below; no migration or reservation, grant-policy change, or unrelated topology change.
DRAFT / readiness and deployment blocked. The existing optionalAuth sealed-session platform-ban omission is a separate High blocker, now being fixed separately from
main. This PR must be rebased/composed after that fix before readiness or deployment, followed by fresh review and exact-head CI. This publication preserves the reviewed blobs and performs no rebase. Human maintainer approval is required; requesting review or receiving bot review is not approval. This is one #6827 slice only, not issue closure or a merge-ready claim.Exact stack and reviewed candidate
Stack: #7462 -> #7461 -> #7477 -> this draft.
Base branch:
conductor/addie-explicit-organization(the exact branch of #7477, notmain).3e5b6c7159327d6731ec88eb412c7cf6e080ba360734eb014e56887f30f925d11a74b74c7cca98d7d8dbeca51d30d4d0535c1f1fba981837c86bd5146cb4b16fb2bdd83ace7beb2b414e9fc6b5f09998One commit:
fix(auth): preserve sealed bearer organization selection.Three files, 509 additions / 10 deletions (production source: 47 additions / 10 deletions):
server/src/middleware/auth.tsserver/src/routes/helpers/resolve-caller-org.tsserver/tests/integration/sealed-bearer-organization.test.tsLocal evidence on the reviewed tree
npm run precommit: passed. Root Vitest: 1,063 passed / 71 files, plus 50 Node guard/vector checks. Full server units: 9,957 passed, 31 intentionally skipped / 619 files. Repository typecheck, including fixed-trace rollout checks, passed.npm run test:migrations: 3 passed. Image guard and diff whitespace checks passed.Mounted coverage includes no selector with zero/one/many orgs; all supported header/query/body/path selectors; exact membership and grant-only access; selector conflicts; absent, expired, future, revoked, mismatched, and sibling-only grants; inactive membership; DB/provider outages; credential deletion; snapshot/epoch/grant changes; forged HTTP fields; changed token/principal/snapshot; refreshes; concurrent cache hits; cross-cookie/bearer and required/optional cache isolation; and real conformance-token route composition.
Broad integration was not green:
DATABASE_URL=<local test database> npm run test:server-integrationfinished with 2,325 passed / 4 failed / 8 skipped across 165 files. The failures were a community-mirror setup timeout, two registry setup/snapshot timeouts, and the creative-lifecycle webhook timeout. Full reruns of the three affected suites produced 96 passed / 2 failed out of 98; the mirror suite passed, and registry encountered another snapshot-deadline-induced public-only comparison failure. A subsequent isolated full registry run passed 45/45 without source or timeout changes.The remaining
training-agent-webhooks.test.ts:1001creative-lifecycle webhook timeout was reproduced on the untouched published parent, using the same unchanged retained assets in a separate database: 14 passed / 1 identical 15-second timeout out of 15. No registry or training-agent code/deadlines were altered. These follow-ups do not turn the original broad run into a green run.Skipped local lanes: 28 opt-in live Addie model scenarios plus 3 explicitly skipped schema examples in the unit suite; 7 opt-in live creative-agent comparisons plus 1 retained GCS evidence case in integration. The documentation/schema-heavy
npm testmonolith was not run. Live WorkOS cryptography/revocation and an actual native client were not verified.Publication pre-push evidence: the advisory local storyboard matrix (selected by the hook against the inherited stack relative to
origin/main) failed because compliance cache3.2.0-rc.2is unsupported by the test seller, whose advertised versions stop at3.2-rc.1; isolated storyboard discovery also failed. The repository-documentedADCP_SKIP_STORYBOARD_MATRIX=1override is used for draft publication, with the remaining push checks retained. The separate local 3.0 compatibility run is skipped with that matrix. This is not a passing storyboard result; authoritative CI remains required. No reviewed source or generated tracked blobs were changed.Independent review and remaining constraints
An independent security/delta reviewer verified exact tree
d8dbeca51d30d4d0535c1f1fba981837c86bd514before and after review against the exact parent and found no introduced blocker or actionable delta finding. Review covered authorization bypass, marker forgery, token/principal confusion, cache contamination, stale authorization, optionalAuth marker/snapshot parity, sibling isolation, cookie compatibility, and scope.The existing 60-second provider-authentication cache remains. Fresh local snapshots do not establish immediate remote WorkOS session revocation, and live WorkOS revocation was not verified. The separate High optionalAuth platform-ban blocker described above remains a prerequisite to readiness/deployment. Existing authorization-to-action timing limitations also remain.
Keep this PR in Draft with auto-merge off. Human approval and fresh CI on the eventual composed exact head are required before any readiness/deployment decision. Related to #6827; does not close it.
Open workspace in Conductor
Draft disposition — 2026-10-09
This draft is retained for the stated workstream. Continue on this existing branch; no parallel PR is needed. This disposition does not waive CI, review, migration, or release gates.