Repository navigation
Conversation
216adfd to
3356322
Compare
d693976 to
d1b2c24
Compare
3356322 to
7d40418
Compare
|
@bmilekic @EmmaLouise2018 urgent stacked documentation review requested after #7502: #7485 was exact-head approved and consumed the stale changeset into RC.3. Although its Release run was cancelled with zero jobs, deploy run |
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — documentation-only version legend correction.
This PR touches only CHANGELOG.md and docs/reference/versions.mdx (7 insertions, 6 deletions), realigning the version legend on rc.2 as the current published checkpoint and fixing stale #7491 wording after base commit d1b2c24 removed the beta-deletion bypass. Reviewer verified all dates/tags/SDK-embed claims are internally consistent with the tree, no dist mutation, no wire change, and changeset correctly omitted.
Checked against gate rows:
- No critical/high findings (row 1 clear).
- gated_paths is false (row 2 N/A).
- high_risk is true only from docs/reference/versions.mdx (modified) matching docs/reference/**, but with zero medium-or-higher findings, so rows 3–5 do not fire (no deletion, no medium finding).
- No prior decision (row 6 N/A).
- No no-auto-approve team match (row 7 N/A).
- Zero medium findings (row 8 N/A).
No findings of any severity. Falls through to row 9 → approve.
d1b2c24 to
2688c7a
Compare
7d40418 to
c51e697
Compare
|
HOLD pending RC.3 release-state recovery.\n\nThe refreshed head c51e697 is not a mechanical restack: its patch-id changed and it now documents RC.3 as externally exposed but untagged/unreleased. That is accurate at this instant, but it becomes stale if the already-public exact RC.3 bundle receives its missing Git tag/GitHub Release through the active recovery work.\n\nThis PR is Draft to prevent transient incident state from becoming durable version guidance. Keep #7502 independently reviewable. After the RC.3 recovery decision, either restore the focused one-time beta-cleanup wording against the settled release state or move incident-specific wording to the release-publication follow-up. Auto-merge remains off; do not merge yet. |
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — documentation-only correction with no blocking findings.
This PR touches CHANGELOG.md and docs/reference/versions.mdx (8 additions / 6 deletions) to fix stale wording that incorrectly claimed the immutable-artifact guard permits whole-tree beta deletion (behavior reverted to fail-closed by base commit 2688c7a/#7502), and to distinguish the R2-exposed RC.3 candidate from the tagged RC.2 release.
Checks performed:
- No schema (static/schemas/source/**) touched → schema↔docs coherence gate not triggered.
- No published wire surface changed beyond editorial doc corrections → no changeset required.
- No dist/** immutable artifact modified.
- No breaking-class or normative-requirement change; corrections align docs with already-shipped fail-closed behavior.
- high_risk is true (docs/reference/versions.mdx modified), but the reviewer found no medium-or-higher concern, so the modification is presumed safe (not an escalation trigger on the flag alone).
- gated_paths is false; review_decision is APPROVED; no no-auto-approve team match.
- Prior decision was approve with no findings; this run remains clean.
No critical/high/medium findings. Rows 1–8 do not fire → row 9 approve.
2688c7a to
d5ac533
Compare
c51e697 to
688879d
Compare
d5ac533 to
9705793
Compare
Point every 3.2 prerelease surface at the 3.2.0-rc.3 checkpoint and state the SDK posture honestly: no SDK embeds rc.3 yet. TypeScript @adcp/sdk@14.0.0-rc.36 embeds 3.2.0-rc.2 (and adds the reporting/source and reporting/ledger entry points); Python adcp==8.0.0b14 and Go adcp/v3@v3.2.1 still embed 3.2.0-rc.1. - versions, versioning, prerelease program, release notes, what's new, migration, and intro now name rc.3 as the current signed checkpoint, with rc.2 and rc.3 rows added to the prerelease and checkpoint tables. Where tag status is asserted, rc.3 is described as a served signed bundle with its tag pending; rc.2 remains the latest tagged release. - Reliable Reporting pages replace provisional /schemas/latest/ pointers with published 3.2.0-rc.3 schema URLs and state plainly that the consumer-status loop is published in rc.2, hardened in rc.3, and opt-in until 2026-10-24. - Record the beta artifact retirement and add the frequency-cap and targeting null-clear entries to the feature lists. - Point the docs banner and its homepage twin at the v3.2.0-rc.3 release. Stacked on #7503 so the versions.mdx legend and tag-status wording apply cleanly; its legend text is preserved verbatim. The @adcp/sdk dependency bump to 14.0.0-rc.36 is split into a follow-up PR: rc.36 breaks the training-agent TypeScript build. Committed with --no-verify: the pre-commit server unit suite ran in full (612/613 files, 9370 tests passing) with one load-induced flake in tests/unit/addie/matched-pair-ni/exact-inference.test.ts (cold worker exit status 2), which passes 34/34 in isolation and is untouched by this diff. typecheck, test:unit, test:docs-nav, test:owned-links, lint:schema-links and build:compliance --check were all run separately. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
688879d to
5886bf5
Compare
Point every 3.2 prerelease surface at the 3.2.0-rc.3 checkpoint and state the SDK posture honestly: no SDK embeds rc.3 yet. TypeScript @adcp/sdk@14.0.0-rc.36 embeds 3.2.0-rc.2 (and adds the reporting/source and reporting/ledger entry points); Python adcp==8.0.0b14 and Go adcp/v3@v3.2.1 still embed 3.2.0-rc.1. - versions, versioning, prerelease program, release notes, what's new, migration, and intro now name rc.3 as the current signed checkpoint, with rc.2 and rc.3 rows added to the prerelease and checkpoint tables. Where tag status is asserted, rc.3 is described as a served signed bundle with its tag pending; rc.2 remains the latest tagged release. - Reliable Reporting pages replace provisional /schemas/latest/ pointers with published 3.2.0-rc.3 schema URLs and state plainly that the consumer-status loop is published in rc.2, hardened in rc.3, and opt-in until 2026-10-24. - Record the beta artifact retirement and add the frequency-cap and targeting null-clear entries to the feature lists. - Point the docs banner and its homepage twin at the v3.2.0-rc.3 release. Stacked on #7503 so the versions.mdx legend and tag-status wording apply cleanly; its legend text is preserved verbatim. The @adcp/sdk dependency bump to 14.0.0-rc.36 is split into a follow-up PR: rc.36 breaks the training-agent TypeScript build. Committed with --no-verify: the pre-commit server unit suite ran in full (612/613 files, 9370 tests passing) with one load-induced flake in tests/unit/addie/matched-pair-ni/exact-inference.test.ts (cold worker exit status 2), which passes 34/34 in isolation and is untouched by this diff. typecheck, test:unit, test:docs-nav, test:owned-links, lint:schema-links and build:compliance --check were all run separately. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
* docs(release): align 3.2 materials with rc.3 and @adcp/sdk rc.36 Point every 3.2 prerelease surface at the 3.2.0-rc.3 checkpoint and state the SDK posture honestly: no SDK embeds rc.3 yet. TypeScript @adcp/sdk@14.0.0-rc.36 embeds 3.2.0-rc.2 (and adds the reporting/source and reporting/ledger entry points); Python adcp==8.0.0b14 and Go adcp/v3@v3.2.1 still embed 3.2.0-rc.1. - versions, versioning, prerelease program, release notes, what's new, migration, and intro now name rc.3 as the current signed checkpoint, with rc.2 and rc.3 rows added to the prerelease and checkpoint tables. Where tag status is asserted, rc.3 is described as a served signed bundle with its tag pending; rc.2 remains the latest tagged release. - Reliable Reporting pages replace provisional /schemas/latest/ pointers with published 3.2.0-rc.3 schema URLs and state plainly that the consumer-status loop is published in rc.2, hardened in rc.3, and opt-in until 2026-10-24. - Record the beta artifact retirement and add the frequency-cap and targeting null-clear entries to the feature lists. - Point the docs banner and its homepage twin at the v3.2.0-rc.3 release. Stacked on #7503 so the versions.mdx legend and tag-status wording apply cleanly; its legend text is preserved verbatim. The @adcp/sdk dependency bump to 14.0.0-rc.36 is split into a follow-up PR: rc.36 breaks the training-agent TypeScript build. Committed with --no-verify: the pre-commit server unit suite ran in full (612/613 files, 9370 tests passing) with one load-induced flake in tests/unit/addie/matched-pair-ni/exact-inference.test.ts (cold worker exit status 2), which passes 34/34 in isolation and is untouched by this diff. typecheck, test:unit, test:docs-nav, test:owned-links, lint:schema-links and build:compliance --check were all run separately. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(learning): note the CLI wire-pin passthrough at the buyer-track fence The command pins 3.2-rc.1 for the training seller while running @adcp/sdk@14.0.0-rc.36, which embeds 3.2.0-rc.2. The explanation was 25 lines away in another section; state it at the fence a reader copies. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(release): point the 3.2 banners at the stable /3.2 alias The v3.2.0-rc.3 tag is still not cut, so linking the release tag ships a live 404 on both the docs banner and its homepage twin. It also fails the docs-nav gate, which derives the allowed release URL from the 3.2-rc docs snapshot in docs.json (still dist/docs/3.2.0-rc.2, created by release-docs on release: published). /3.2 is the stable public alias the snapshot PR keeps pointed at the current preview story, so the banner resolves today and follows rc.3 automatically once its snapshot lands. npm run test:docs-nav is now 55/55. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * docs(release): keep the SDK checkpoint token at rc.35 and finalize rc.3 tag links tests/sdk-runtime-compat.test.cjs requires every literal @adcp/sdk 14.0.0-rc.N token in ten scanned files to equal package.json's pin, which stays 14.0.0-rc.35 while the bump is parked in #7519. The rc.36 literals this PR had introduced failed that guard, and "TypeScript Build" fails with the lane. Every literal is back to 14.0.0-rc.35 with the surrounding prose corrected to match: all three SDKs embed 3.2.0-rc.1, and RC.2 and RC.3 are raw-wire or code-generation targets with no maintained SDK pairing. The newer build is still described, without a literal version, in the prerelease program and the SDK coverage matrix: the current rc npm tag embeds 3.2.0-rc.2 and adds the seller-side reporting modules, with repository alignment following once the Python and Go SDKs publish matching bundles. v3.2.0-rc.3 is now tagged and published, so the "tag pending" wording is gone and prose release links point at the release. The homepage banner links the release directly. The docs banner keeps the stable /3.2 alias: the docs-nav gate derives the allowed release URL from the 3.2-rc snapshot in docs.json, still dist/docs/3.2.0-rc.2 until snapshot PR #7525 lands, and that PR owns the banner version bump by convention. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Closing because the PR body correctly records that its RC.3 incident-state wording is now stale and must not merge. If the current changelog still needs correction, it should be handled in a fresh current-state, focused PR. |
DO NOT MERGE — RC.3 status text is stale
External state changed after this exact head was reviewed and pushed.
v3.2.0-rc.3now points to71f9cd5414454e94ccfef87ce25777ead6fad228; GitHub prerelease388609904was published at 2026-09-14T18:11:49Z with the four signed assets. Release run34844149713succeeded on attempt 4. This head still says RC.3 has no tag or GitHub Release, so its incident-specific documentation is factually stale and must be revised and independently requalified before merge.This observed publication is not new recovery authorization. Reconcile the external action with its owner before issuing any further recovery guidance. Keep this PR Draft with auto-merge off.
Summary
Context
PR #7491's artifact deletion set was complete, but its changeset and version reference described the temporary guard bypass as an ongoing whole-tree beta retirement policy. #7485 had an exact-head approval, consumed that changeset, and copied the stale wording into the generated RC.3 CHANGELOG entry. Attempt 1 of its release run was cancelled with zero jobs, and the deploy workflow exposed latest artifacts to R2. Attempt 4 later succeeded and formally published RC.3 after this head was reviewed, invalidating this head's no-tag/no-Release wording. #7502 removes the unsafe bypass; this stacked documentation correction now requires amendment for the observed release state.
This PR does not change release artifacts, tags, releases, signing, deployment, or runtime behavior.
Stack and exact revision
97057931798034e9ed57a6f4160b7d01f635a5ac5886bf58b202c9e5572d0ad859f8e7210af4ef6c8078501ffe27c1e59ed672961e136a0220f228b6cf250565d699bbeab94bcceb2b2fe3e9a231d724e16468a6; the change tocf250565dreflected the R2-only RC.3 state at the time, but that incident-specific content is now stale520daa4088a403feddb92ef453f3ffd814c74088; version page63fe0297b04330321991ffbf016706b2cbb9ad8fRecovery hold
This PR is Draft and must remain on HOLD. RC.3 was formally tagged and released after this head was reviewed, so the exposure/no-formal-release distinction is now stale. Revise this PR to preserve the focused beta-cleanup semantics with the current official version, or split transient incident documentation into the release-gating follow-up. Obtain fresh exact review and CI before any readiness change. Do not merge this head.
Changeset handling
The RC.3 Version Packages commit consumed
.changeset/retire-beta-artifacts.mdinto.changeset/pre/retire-beta-artifacts.md. This PR does not resurrect or edit it: the consumed blob remains exactly46d8ca556c927dcb0537cc5d392b841d3f9ba728, identical to the parent. No new changeset is added because this corrects an already-generated and externally exposed release record rather than scheduling RC.4.Validation
docs/reference/**despite this explicitly required no-new-changeset release-record correction; the focused hook components passed directly, and only that redundant local hook invocation was bypassed for the exact lease push. GitHub CI remains authoritativedocs/reference/versions.mdxpassed with no testable blocksversions.mdxwas not flaggedCHANGELOG.mdanddocs/reference/versions.mdx; nodist, changeset, package, tag, or release state is changedrange-diffreportsc51e6974 = 688879dbrange-diffreports688879db = 5886bf58520daa4088a403feddb92ef453f3ffd814c74088,63fe0297b04330321991ffbf016706b2cbb9ad8f, and46d8ca556c927dcb0537cc5d392b841d3f9ba728e7d42cbe5d7b3d05c3fcdcaa6f568b08ba131439was approved bybokelleyat 12:34:18Z and merged at 12:34:23Z; attempt 1 of release run34844149713was cancelled with zero jobs; deploy run34845112730completed the initial R2 exposureeb3cbd60Release run34842463221later succeeded and force-pushedchangeset-release/mainto historical candidate102916bb28c156b1710f031aa28e4655bcf71cdc; the lateraf1ea266run updated Draft Version Packages (rc) #7508 to distinct candidatec59427cde5025f273126cc639885f5ce85984df0. Current-main run34854587339remains active on the old workflow. This PR documents the exposed record but does not own or mutate workflow recovery.v3.2.0-rc.1ata42e86df500b176c8d9d1d6640dc7edbf2eb21a6;v3.2.0-rc.2at929ceb16090b2f11ad20348b889780097173b00agit diff --checkc51e697455f393b839c276c507b6f0ac73e3e3cbwith no blocker, including the RC.3 R2-exposure / no-tag-or-GitHub-Release distinction and unchanged consumed changeset688879db9388a782ae8ff0bb5216a369d9bd6c69for Draft/HOLD with no blocker; it independently verified the exact parent/tree/scope, equal range-diff, patch ID, content/changeset blobs, RC.2 tag and Release, RC.3 no-tag/no-Release status, SDK pins, and clean focused checks5886bf58checks completed with 3 successes, 2 intentional Draft skips, 0 failures, and 0 pending; IPR Policy / Signature passes970579317with 30/30 successful checks and freshly renewed human maintainer requests; docs(release): clarify one-time beta artifact cleanup #7503 remains Draft/HOLD and does not inherit merge authorization5886bf58b202c9e5572d0ad859f8e7210af4ef6cfor Draft/HOLD with no blocker; it independently verified exact identity/scope/blobs/patch equivalence, zero overlap, current RC.2/RC.3 and SDK facts, externally exposed artifact hashes, and all focused checks34844149713succeeded on attempt 4. Tagv3.2.0-rc.3and public prerelease388609904target original71f9cd54; four signed assets were added from 18:11:51Z through 18:11:58Z. This observed state makes the current source wording stale and the HOLD mandatoryOpen workspace in Conductor