Skip to content

fix(addie): shorten stale admin-denial cache window #7535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
garvitkaushik-123 wants to merge 1 commit into from
Closed

fix(addie): shorten stale admin-denial cache window #7535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion server/src/addie/admin-status-lookup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ const AAO_ADMIN_WORKING_GROUP_SLUG = 'aao-admin';
// performed an admin grant/revoke. Other replicas must therefore re-check
// membership quickly enough for an emergency revocation to take effect.
export const AAO_ADMIN_POSITIVE_CACHE_TTL_MS = 60 * 1000;
const AAO_ADMIN_NEGATIVE_CACHE_TTL_MS = 5 * 60 * 1000;
const AAO_ADMIN_NEGATIVE_CACHE_TTL_MS = 60 * 1000;

const wgDb = new WorkingGroupDatabase();

Expand Down
5 changes: 2 additions & 3 deletions server/src/addie/mcp/admin-tools.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,7 @@ const KITCHEN_CABINET_SLUG = "kitchen-cabinet";
// Site-admin membership can be revoked on another replica. Keep successful
// membership decisions short-lived so every replica rechecks within a minute.
const ADMIN_POSITIVE_CACHE_TTL_MS = 60 * 1000;
const ADMIN_NEGATIVE_CACHE_TTL_MS = 5 * 60 * 1000;
const ADMIN_NEGATIVE_CACHE_TTL_MS = 60 * 1000;
const COUNCIL_CACHE_TTL_MS = 30 * 60 * 1000;
// Shared cache module — invalidators can be called without dragging the
// rest of admin-tools (and its Anthropic-instantiating dependencies)
Expand Down Expand Up @@ -247,10 +247,9 @@ export async function isSlackUserAAOAdmin(

if (!adminGroup) {
logger.warn("Admin check: aao-admin working group not found in DB");
// Cache the negative result for a shorter time to avoid repeated DB lookups
adminStatusCache.set(slackUserId, {
isAdmin: false,
expiresAt: Date.now() + 5 * 60 * 1000,
expiresAt: Date.now() + ADMIN_NEGATIVE_CACHE_TTL_MS,
});
return false;
}
Expand Down
Loading