Repository navigation
feat(registry): expose agent-wide grading previews - #7542
Conversation
There was a problem hiding this comment.
Ladon verdict: Escalate to human review
Escalate — gated path requires human/CODEOWNERS review.
This PR touches .agents/shortcuts/verification-profile-shadow-rollout.md, which matches the repo's hard approval gate (.agents/**). gated_paths is true and review_decision is REVIEW_REQUIRED (not APPROVED), so decision-table row 2 fires: the gate is not satisfied and the PR cannot be approved or plain-commented.
No blocking findings exist — the reviewer reported no Critical/High/Medium issues. Owner-scope gating (registry-api.ts:6945), migration 591 backfill safety, bounded/fail-closed DB paths, schema↔OpenAPI coherence, and correct changeset absence were all verified clean. Migration 591 is a new file (added), so the high-risk flag alone does not escalate. The escalation is purely the deterministic gated-path requirement.
Escalation reasons
.agents/shortcuts/verification-profile-shadow-rollout.mdis under the.agents/**hard approval gate; requires human/CODEOWNERS review (review_decisionis currentlyREVIEW_REQUIRED).
Once a human/CODEOWNERS approval lands (review_decision: APPROVED), this clean diff can fall through to approve.
Why human review
- .agents/shortcuts/verification-profile-shadow-rollout.md matches the .agents/** hard approval gate and review_decision is REVIEW_REQUIRED — human/CODEOWNERS approval required before merge.
- This PR touches a path under a hard, non-overridable approval gate (.agents/shortcuts/verification-profile-shadow-rollout.md (modified) matches
.agents/**) and the current GitHub review decision is 'REVIEW_REQUIRED', not APPROVED. This is a hard gate enforced in code — Ladon cannot auto-approve until a human/CODEOWNERS approval is recorded, regardless of how clean the diff is.
|
Migration-number collision: this PR adds 591_enable_verification_profile_comparisons.sql, but open Draft #7457 already reserves 591 as 591_compliance_refresh_authenticated_credential.sql and predates this PR. Current main contains neither. Please renumber this newer migration to the next free number (currently >=598, after rechecking immediately before the change), update references/tests, and rerun migration apply/replay plus exact-head CI. Downstream 592-597 work is being held until this is resolved. |
|
Fixed in the follow-up commit on this branch. Changes made:
598 is the first free number after verifying open drafts hold 591–597 (per your note). No other files referenced the old migration name. Generated by Claude Code |
|
Correction after live-main verification: #7542 merged at 19:41:59 UTC before the collision note, so 591_enable_verification_profile_comparisons.sql is now an immutable mainline/applied allocation. Do not rename or remove that landed migration in a follow-up. The unmerged #7457 migration must move off 591 instead. If the post-merge branch changes are being prepared for another PR, please retain landed 591 and avoid introducing a rename-only 598 migration. |
Summary
Scope
This is the safe Phase 1 rollout from #7540: an agent-wide, read-only preview. It is not an exact badge-role grade. Legacy remains authoritative, and profile selection or enforcement is intentionally disabled pending the working-group decisions tracked on the issue.
Testing
npm run precommit(71 root files / 1,063 tests; 617 server files / 9,492 passed, 31 skipped)npm run test:openapiProgresses #7540
Open workspace in Conductor