Skip to content

fix(addie): renumber surface telemetry migration - #7590

Merged
bokelley merged 1 commit into
mainfrom
fix/addie-surface-telemetry-migration
Sep 18, 2026
Merged

bokelley merged 1 commit into
mainfrom
fix/addie-surface-telemetry-migration

Conversation

@bokelley

@bokelley bokelley commented Sep 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • renumber the unapplied Addie Gemini Direct surface telemetry migration from 599 to 600
  • preserve the migration SQL byte-for-byte; only the ledger version/filename changes
  • avoid the production ledger collision with the previously applied 599_compliance_refresh_authenticated_credential.sql

Diagnosis

Production correctly rejected the release because migration version 599 is already recorded under a different filename. That historical migration was merged in #7457 and applied before its source file was later removed from main. The Addie migration from #7587 therefore cannot reuse 599 even though current main contains no second 599 file.

Migration 600 is the next number after current main, has no repository-history claimant, and is not used by an open migration PR.

Validation

  • npm run test:migrations (3 passed)
  • npx vitest run --config server/vitest.config.ts server/tests/unit/migrate.test.ts (26 passed)
  • mandatory pre-commit gate:
    • root unit suite: 1,063 passed
    • server unit suite: 10,812 passed, 31 skipped across 648 files
    • TypeScript and fixed-trace rollout typecheck passed

Deployment

After required review and final-head CI are green, merge normally and allow exactly one production deployment for the corrected main commit. Verify migration 600, Fly convergence, artifact publication, and database/Addie/MCP/chat health. The failed deployment left the prior healthy release active.


Open workspace in Conductor

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Approve

Approve — migration renumber, no blocking or medium findings.

This PR renames the unapplied Addie surface-telemetry migration 599→600, preserving SQL byte-for-byte (0 additions / 0 deletions). Reviewer confirmed the fix against migrate.ts:476-497: production applied version 599 under the compliance filename (#7457, source removed in #7580), so #7587's second 599 file tripped the >389 filename-mismatch guard and blocked startup. Renaming to 600 (unclaimed on disk and across git history, next after main's highest) clears the collision and applies cleanly.

Gate checks:

  • No no-auto-approve team match.
  • gated_paths: false — row 2 does not apply despite review_decision REVIEW_REQUIRED.
  • high_risk is true, but the sole reason is a (renamed) file — treated as a modification. Not a deletion (row 3 N/A), and there are no medium findings, so row 5 does not fire.
  • No changeset owed (migration-only, no published protocol surface); dist immutability and runner locks/timeouts untouched.
  • No critical/high/medium findings.

None of rows 1-8 fire → row 9 approve.

@bokelley
bokelley merged commit 3842ba5 into main Sep 18, 2026
34 checks passed
@bokelley
bokelley deleted the fix/addie-surface-telemetry-migration branch September 18, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant