Repository navigation
fix(addie): renumber surface telemetry migration - #7590
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Ladon verdict: Approve
Approve — migration renumber, no blocking or medium findings.
This PR renames the unapplied Addie surface-telemetry migration 599→600, preserving SQL byte-for-byte (0 additions / 0 deletions). Reviewer confirmed the fix against migrate.ts:476-497: production applied version 599 under the compliance filename (#7457, source removed in #7580), so #7587's second 599 file tripped the >389 filename-mismatch guard and blocked startup. Renaming to 600 (unclaimed on disk and across git history, next after main's highest) clears the collision and applies cleanly.
Gate checks:
- No no-auto-approve team match.
- gated_paths: false — row 2 does not apply despite review_decision REVIEW_REQUIRED.
- high_risk is true, but the sole reason is a (renamed) file — treated as a modification. Not a deletion (row 3 N/A), and there are no medium findings, so row 5 does not fire.
- No changeset owed (migration-only, no published protocol surface); dist immutability and runner locks/timeouts untouched.
- No critical/high/medium findings.
None of rows 1-8 fire → row 9 approve.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
599_compliance_refresh_authenticated_credential.sqlDiagnosis
Production correctly rejected the release because migration version 599 is already recorded under a different filename. That historical migration was merged in #7457 and applied before its source file was later removed from
main. The Addie migration from #7587 therefore cannot reuse 599 even though currentmaincontains no second 599 file.Migration 600 is the next number after current
main, has no repository-history claimant, and is not used by an open migration PR.Validation
npm run test:migrations(3 passed)npx vitest run --config server/vitest.config.ts server/tests/unit/migrate.test.ts(26 passed)Deployment
After required review and final-head CI are green, merge normally and allow exactly one production deployment for the corrected
maincommit. Verify migration 600, Fly convergence, artifact publication, and database/Addie/MCP/chat health. The failed deployment left the prior healthy release active.Open workspace in Conductor