Skip to content

test(training-agent): derive validator-gate seed passes from fixtures #7976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bokelley merged 1 commit into from
Oct 6, 2026
Merged

test(training-agent): derive validator-gate seed passes from fixtures #7976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions server/tests/integration/training-agent-tool-catalog-drift.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,13 +152,15 @@ describe('tool-catalog drift detection', () => {
expect(tools).toContain('comply_test_controller');
expect(tools).not.toContain('validate_input');
expect(toolsForTenant(tenant)).not.toContain('validate_input');
for (const [name, seedPasses] of [
['ctv-experience-validate-input', 14],
['premium-display-canonical-validation', 18],
] as const) {
for (const name of ['ctv-experience-validate-input', 'premium-display-canonical-validation'] as const) {
const storyboard = YAML.parse(readFileSync(new URL(
`../../../static/compliance/source/universal/${name}.yaml`, import.meta.url,
), 'utf8')) as Storyboard;
// The runner seeds every fixture product and fixture account through the
// controller, so those seeds are the only passes the old OR gate earned.
const fixtures = (storyboard as { fixtures?: { products?: unknown[]; accounts?: unknown[] } }).fixtures;
const seedPasses = (fixtures?.products?.length ?? 0) + (fixtures?.accounts?.length ?? 0);
expect(seedPasses).toBeGreaterThan(0);
const options = {
auth: { type: 'bearer' as const, token: 'tool-catalog-drift-token' },
allow_http: true,
Expand All @@ -177,7 +179,7 @@ describe('tool-catalog drift detection', () => {
const passed = steps.filter(step => step.passed && !step.skipped);
expect(passed).toHaveLength(seedPasses);
expect(passed.every(step => step.task === 'comply_test_controller'
&& step.step_id.startsWith('seed_product.'))).toBe(true);
&& (step.step_id.startsWith('seed_product.') || step.step_id.startsWith('seed_account.')))).toBe(true);
const validators = steps.filter(step => step.task === 'validate_input');
expect(validators).toHaveLength(storyboard.phases.reduce((n, phase) => n + phase.steps.length, 0));
expect(validators.every(step => step.skipped && step.skip_reason === 'missing_tool')).toBe(true);
Expand Down
Loading