Repository navigation
Conversation
Brian's concession on #8519 (2026-11-06), confirmed at the 2026-11-09 working-group session, replaced the proposed blanket `high` on every minor-release change with one reviewer check: rule 4 of the versioning rules (#8704). A field added to a mutating request in a minor is `high` when an older seller that ignores it would commit to something different, unless it sits behind a capability the seller declares and buyers MUST NOT send it otherwise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the reviewer check that Brian's concession on #8519 promised, and that the working-group session of 2026-11-09 confirmed. #8519 proposed a blanket
highon every minor-release change that didn't state a "pathway back". That blanket rule is replaced by one check: rule 4 of "What can change in a release" indocs/reference/versioning.mdx(#8704).The check
For a PR on
main, which ships in a minor, Ladon checks each field added to a mutating request, including nested objects such as packages. Would a seller on the previous minor of the same major ignore the field and commit to something different? Spend, targeting, caps, bidding, creative activation, measurement and account identity are examples, not the full list.If so, the field is
highunless:get_adcp_capabilities, andA field an older seller can safely ignore needs nothing more.
This PR doesn't add the "pathway back" labels or the constitution invariant that #8519 proposed.
Notes
LADON.mdonly. No changeset: it isn't on the protocol surface, andnode scripts/check-changeset-protocol-scope.cjs origin/mainpasses.ai-review.ymlskips Ladon review when a PR modifiesLADON.md, so this needs a human reviewer and a human merge.🤖 Generated with Claude Code