Skip to content

fix(build): stop tracking compiled compliance modules - #8874

Open
Synaeve wants to merge 2 commits into
adcontextprotocol:mainfrom
Synaeve:fix/8817-ignore-compiled-compliance
Open

Synaeve wants to merge 2 commits into
adcontextprotocol:mainfrom
Synaeve:fix/8817-ignore-compiled-compliance

Conversation

@Synaeve

@Synaeve Synaeve commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Closes #8817

Problem

server/tsconfig.json compiles server/src/compliance/* into dist/compliance/. .gitignore re-includes dist/compliance for the released bundles but, unlike dist/schemas, has no rule for compiled JavaScript at its top level. Every npm run build rewrites the four tracked storyboard-runner-options.* files (stale since #8272) and leaves the other compiled modules untracked.

Changes

.gitignore

  • Ignores *.js, *.js.map, *.d.ts and *.d.ts.map at the top level of dist/compliance, matching the dist/schemas rules. The patterns are anchored, so version folders such as dist/compliance/3.2.9/ are unaffected.

dist/compliance/storyboard-runner-options.*

  • The four committed build outputs are no longer tracked (git rm --cached). The build still writes them. Nothing imports the committed copies: callers use server/src/compliance/storyboard-runner-options.ts, and tests/cdn-artifacts.test.cjs already expects the file to be excluded from CDN uploads.

Tests

  • git check-ignore matches dist/compliance/storyboard-runner-options.js to the new rule.
  • No tracked file under a dist/compliance/<version>/ folder matches the new patterns.

Changeset

Patch. dist/compliance/ is on the changeset check's protocol-scoped path list, so untracking files there needs one, as #7968 did for the same files. The released dist/compliance/<version>/ bundles are unchanged.

🤖 Generated with Claude Code

build
- ignore compiler output at the top of dist/compliance
- untrack the stale storyboard-runner-options build output

Closes adcontextprotocol#8817
@mintlify

mintlify Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Preview approval required

This pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit 5912efc.

Approve preview

@aao-secretariat aao-secretariat Bot added the ladon/needs-human-review Ladon has escalated this PR for human review. label Nov 10, 2026

@aao-secretariat aao-secretariat Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ladon verdict: Escalate to human review

Escalate — deletions in a high-risk path require human review.

This PR is a build-hygiene change: .gitignore gains four anchored patterns mirroring the existing dist/schemas rules, and four top-level compiled outputs under dist/compliance/ are removed from tracking. The reviewer found no issues — the removed storyboard-runner-options.* files are regenerated every build, imported by no caller, and already asserted excluded from CDN upload by tests. Crucially, the anchored patterns (/dist/compliance/*) leave versioned dist/compliance/<semver>/ artifacts untouched, so immutable released artifacts are preserved.

However, all four removed files match the high-risk glob dist/** with change-kind (deleted). Per the arbiter decision rules (row 3), any (deleted) entry in a high-risk path always merits escalation — deletions in sensitive paths are rare and hard to recover from if the classification is wrong. A human should confirm these are mutable top-level build outputs and not pinned release records before merge.

Escalation reasons:

  • Deletes 4 tracked files under dist/compliance/ (storyboard-runner-options.d.ts, .d.ts.map, .js, .js.map) — deletions in the high-risk dist/** path require human confirmation that no immutable semver artifact is affected.

Why human review

  • Deletes 4 tracked files under dist/compliance/ (storyboard-runner-options.d.ts, .d.ts.map, .js, .js.map) matching high-risk path dist/** — deletions in sensitive artifact paths require human review to confirm no immutable semver release record is affected.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ladon/needs-human-review Ladon has escalated this PR for human review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

npm run build dirties dist/compliance: compiled server modules land in a tracked folder

1 participant