Repository navigation
Conversation
build - ignore compiler output at the top of dist/compliance - untrack the stale storyboard-runner-options build output Closes adcontextprotocol#8817
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
There was a problem hiding this comment.
Ladon verdict: Escalate to human review
Escalate — deletions in a high-risk path require human review.
This PR is a build-hygiene change: .gitignore gains four anchored patterns mirroring the existing dist/schemas rules, and four top-level compiled outputs under dist/compliance/ are removed from tracking. The reviewer found no issues — the removed storyboard-runner-options.* files are regenerated every build, imported by no caller, and already asserted excluded from CDN upload by tests. Crucially, the anchored patterns (/dist/compliance/*) leave versioned dist/compliance/<semver>/ artifacts untouched, so immutable released artifacts are preserved.
However, all four removed files match the high-risk glob dist/** with change-kind (deleted). Per the arbiter decision rules (row 3), any (deleted) entry in a high-risk path always merits escalation — deletions in sensitive paths are rare and hard to recover from if the classification is wrong. A human should confirm these are mutable top-level build outputs and not pinned release records before merge.
Escalation reasons:
- Deletes 4 tracked files under
dist/compliance/(storyboard-runner-options.d.ts,.d.ts.map,.js,.js.map) — deletions in the high-riskdist/**path require human confirmation that no immutable semver artifact is affected.
Why human review
- Deletes 4 tracked files under dist/compliance/ (storyboard-runner-options.d.ts, .d.ts.map, .js, .js.map) matching high-risk path dist/** — deletions in sensitive artifact paths require human review to confirm no immutable semver release record is affected.
Closes #8817
Problem
server/tsconfig.jsoncompilesserver/src/compliance/*intodist/compliance/..gitignorere-includesdist/compliancefor the released bundles but, unlikedist/schemas, has no rule for compiled JavaScript at its top level. Everynpm run buildrewrites the four trackedstoryboard-runner-options.*files (stale since #8272) and leaves the other compiled modules untracked.Changes
.gitignore*.js,*.js.map,*.d.tsand*.d.ts.mapat the top level ofdist/compliance, matching thedist/schemasrules. The patterns are anchored, so version folders such asdist/compliance/3.2.9/are unaffected.dist/compliance/storyboard-runner-options.*git rm --cached). The build still writes them. Nothing imports the committed copies: callers useserver/src/compliance/storyboard-runner-options.ts, andtests/cdn-artifacts.test.cjsalready expects the file to be excluded from CDN uploads.Tests
git check-ignorematchesdist/compliance/storyboard-runner-options.jsto the new rule.dist/compliance/<version>/folder matches the new patterns.Changeset
Patch.
dist/compliance/is on the changeset check's protocol-scoped path list, so untracking files there needs one, as #7968 did for the same files. The releaseddist/compliance/<version>/bundles are unchanged.🤖 Generated with Claude Code