Skip to content

Fix ListObjectVersions pagination - #3177

Open
dajiaohuang wants to merge 1 commit into
adobe:mainfrom
dajiaohuang:fix/list-object-versions-pagination
Open

dajiaohuang wants to merge 1 commit into
adobe:mainfrom
dajiaohuang:fix/list-object-versions-pagination

Conversation

@dajiaohuang

@dajiaohuang dajiaohuang commented Oct 22, 2026 •

Copy link
Copy Markdown

Summary

  • Enforce max-keys across version and delete-marker entries, with continuation markers derived from the last returned entry when more entries remain.
  • Resume after the supplied key-marker / version-id-marker pair rather than skipping or repeating versions of the marker key.
  • Add unit and integration coverage for three one-entry pages containing a delete marker and two object versions.

Validation

  • make test-class CLASS=BucketServiceTest: 66 tests passed. The regression failed against the original implementation (the first page returned two versions despite max-keys=1) and passed with this change.
  • make format, make lint, and make typecheck: passed. typecheck compiled the integration test; it was not executed because the integration-test target requires Docker, which was not used.
  • make skip-docker: not green. Read-only classification of the current server Surefire reports found 18 failures across six classes: 15 checksum/chunk assertions tied to sampleFile_large.txt (git ls-files --eol: i/lf w/crlf), two Windows drive-letter URI serialization expectations, and one Windows File.setWritable(false, false) failure. These test classes are outside the changed files. The original command output was truncated, so the suite denominator and pristine-baseline result are unknown.

No Docker daemon, AWS resources, cloud service, or real credentials were used.

@dajiaohuang

Copy link
Copy Markdown
Author

I completed Adobe's CLA signing flow for GitHub account dajiaohuang. After following the bot's documented close-and-reopen refresh, check run 122076833321 still reports that no signed agreement was found for PR head ed840a56a2aa7729682ed9ec7f3028fcbb31a382.

@adobe/open-source-office could you check the signature registration and its association with this GitHub account, and synchronize the CLA check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant