Repository navigation
Fix ListObjectVersions pagination - #3177
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
Author
|
I completed Adobe's CLA signing flow for GitHub account @adobe/open-source-office could you check the signature registration and its association with this GitHub account, and synchronize the CLA check? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max-keysacross version and delete-marker entries, with continuation markers derived from the last returned entry when more entries remain.key-marker/version-id-markerpair rather than skipping or repeating versions of the marker key.Validation
make test-class CLASS=BucketServiceTest: 66 tests passed. The regression failed against the original implementation (the first page returned two versions despitemax-keys=1) and passed with this change.make format,make lint, andmake typecheck: passed.typecheckcompiled the integration test; it was not executed because the integration-test target requires Docker, which was not used.make skip-docker: not green. Read-only classification of the current server Surefire reports found 18 failures across six classes: 15 checksum/chunk assertions tied tosampleFile_large.txt(git ls-files --eol:i/lf w/crlf), two Windows drive-letter URI serialization expectations, and one WindowsFile.setWritable(false, false)failure. These test classes are outside the changed files. The original command output was truncated, so the suite denominator and pristine-baseline result are unknown.No Docker daemon, AWS resources, cloud service, or real credentials were used.