feat(da-assets): edit AEM Assets link-img images, persist as <a> links

[shsteimer]

Summary

• New flags sheet flag aem.assets.editableExternalImages = true, which takes effect together with the existing data-sheet aem.assets.image.type = link. With both set, picking an AEM image inserts a real, editable <img> in the doc. Preview and live get a plain <p><a href title data-edit-as="image"> link, the same way a normally authored link is saved. On reload the link comes back as an image. Alt text is carried in the link title.
• aem.assets.image.type = link without the flag behaves as before (plain link). The flag has no effect unless image.type is link.
• Wired through both the standard and smart-crop insert paths. The focal-point UI is skipped for these images.
• Live preview (prose2aem.js) renders the same <p><a> shape that doc2aem saves.
• Node attr editAs='image' (DOM data-edit-as="image") matches da-parser's presence-only marker (feat(da-parser): add link-img asset delivery type for image nodes da-tools#27).

Depends on adobe/da-tools#27 being merged and published, and on da-collab picking up that parser release.

Demo / testing on the branch

Branch preview, pointed at a locally running da-collab that uses the #27 parser:

https://linkimg--da-live--adobe.aem.live/canvas?da-collab=local#/path

Local setup (temporary, for demos only):

1. da-tools on linkimg, then npm link in da-parser. da-collab on linkimg uses the linked parser (npm link @adobe/da-parser).
2. In da-collab, src/shareddoc.js getBackend().fetch is temporarily changed to call admin.da.live over the internet instead of the da-admin-local binding. Uncommitted, local only.
3. npm run dev in da-collab (serves ws://localhost:4711). Use Chrome; Safari blocks ws://localhost from an https page.
4. Config: data sheet aem.assets.image.type = link, flags sheet aem.assets.editableExternalImages = true.
5. ?da-collab=reset switches back to prod collab.

Documents still go through prod da-admin, so use a throwaway page and don't open it in regular da.live at the same time. Prod collab still has the old parser and would remove the marker.

⚠️ Revert before merging

• Revert the temporary parser bundle commits 268b4f9b and 28de66b5 (deps/da-parser/dist/index.js built from the unpublished Directly uploading an image creates two entries in undo history. #27 branch)
• Bump @adobe/da-parser in package.json to the version published from feat(da-parser): add link-img asset delivery type for image nodes da-tools#27
• npm run build:da-parser and commit the real bundle
• Confirm da-collab is deployed with that parser version
• End-to-end check on the branch preview against prod collab (no ?da-collab override)

Test plan

• da-assets unit tests (config flag derivation incl. flags sheet, insert passthrough, standard + smart-crop paths, link/non-image regressions)
• prose2aem tests (link serialization keeps <p>, other images unaffected)
• Lint clean
• Manual end-to-end with published parser, see above

[aem-code-sync]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

• Re-sync branch

Commits

• 4d3d8c7 ✅ (latest)
• add8df8 ✅
• b349717 ✅
• a8fb762 ✅
• 86f8a09 ✅
• 28de66b ✅
• 1cc7e45 ✅
• e3eb697 ✅
• 268b4f9 ✅
• 23b8314 ✅
• 452536b ✅
• 31d09e3 ✅
• 4925729 ✅
• c16e74b ✅
• 68cd9c1 ✅
• 643dd30 ✅

[besimhu]

For

New aem.assets.image.type = editable-link config value: picking an AEM asset inserts a real editable image, but it persists/publishes as a plain link (so project decoration code can handle it) — round-trips back to an image on reload. Alt is carried in the link title.

Is my understanding that the image will show in the author UI, however for the frontend markdown portion, we are working with the a attribute to format as needed?

[shsteimer]

@besimhu correct. this only changes the authoring UX. it has no impact on how front end code/developers would handle the images selected from dynamic media.