Conversation
hannessolo
reviewed
Sep 29, 2026
hannessolo
left a comment
Contributor
There was a problem hiding this comment.
Not sure why tests are failing, rest looks good
Contributor
|
Contributor
Author
|
@hannessolo @shsteimer the failing test is fixed now with the suggestion from @shsteimer . |
hannessolo
approved these changes
Sep 30, 2026
|
🎉 This PR is included in version 1.0.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds semantic versioning to da-live, mirroring adobe/da-nx#783: GitHub tags/releases only — no npm publish, no deploy (EDS deploys automatically).
Changes
.releaserc.cjs— commit-analyzer, release-notes-generator, changelog (CHANGELOG.md), npm (npmPublish: false, only bumpspackage.json), git (chore(release): … [skip ci]), github. Branch:main.package.json—version: 0.0.0placeholder (rewritten on release),semantic-release/semantic-release-dry/preparescripts, dev deps..github/workflows/lint_test.yaml— same as da-nx:test(PRs + main),release-dry-run(PRs),release(push to main,ADOBE_BOT_GITHUB_TOKEN). Node 24.x, actions v6.config-conventional) via huskycommit-msghook.CLAUDE.md— Commits + Changelog sections..hlxignore— excludecommitlint.config.js.Notes
v1.0.0pushed onmain(749b4bb) so the first release doesn't cover/comment on all prior history. This PR itself has no releasing commits → merge won't cut a release; the nextfix/featon main will.BREAKING CHANGE:footer only (default angular preset ignoresfeat!:).mainis protected: the bot needs permission to push thechore(release)commit.CHANGELOG.mdis created by the first release; don't hand-edit.Verification
npm run lint✅,npm test✅ (2342 passed, 0 failed)bad message, acceptsfeat: xverifyConditionspass, findsv1.0.0, no release for this branchmain