Skip to content

build: add semantic-release for GitHub releases - #1393

Merged
mhaack merged 8 commits into
mainfrom
release
Sep 30, 2026
Merged

mhaack merged 8 commits into
mainfrom
release

Conversation

@mhaack

@mhaack mhaack commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Adds semantic versioning to da-live, mirroring adobe/da-nx#783: GitHub tags/releases only — no npm publish, no deploy (EDS deploys automatically).

Changes

  • .releaserc.cjs — commit-analyzer, release-notes-generator, changelog (CHANGELOG.md), npm (npmPublish: false, only bumps package.json), git (chore(release): … [skip ci]), github. Branch: main.
  • package.json — version: 0.0.0 placeholder (rewritten on release), semantic-release / semantic-release-dry / prepare scripts, dev deps.
  • .github/workflows/lint_test.yaml — same as da-nx: test (PRs + main), release-dry-run (PRs), release (push to main, ADOBE_BOT_GITHUB_TOKEN). Node 24.x, actions v6.
  • Commit enforcement: commitlint (config-conventional) via husky commit-msg hook.
  • CLAUDE.md — Commits + Changelog sections. .hlxignore — exclude commitlint.config.js.

Notes

  • Baseline tag v1.0.0 pushed on main (749b4bb) so the first release doesn't cover/comment on all prior history. This PR itself has no releasing commits → merge won't cut a release; the next fix/feat on main will.
  • Use squash-merge with a conventional PR title — the title is what semantic-release reads and it bypasses the local hook.
  • Breaking changes: BREAKING CHANGE: footer only (default angular preset ignores feat!:).
  • main is protected: the bot needs permission to push the chore(release) commit.
  • CHANGELOG.md is created by the first release; don't hand-edit.

Verification

  • npm run lint ✅, npm test ✅ (2342 passed, 0 failed)
  • Hook rejects bad message, accepts feat: x
  • Local dry run: all verifyConditions pass, finds v1.0.0, no release for this branch
  • CI: Lint & Test, Semantic Release (Dry Run) green; Release skipped
  • Bot allowed to push to protected main

@aem-code-sync

aem-code-sync Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@hannessolo hannessolo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why tests are failing, rest looks good

@shsteimer

Copy link
Copy Markdown
Contributor

@hannessolo

Not sure why tests are failing

m.close is not a function I noticed this and fixed it in #1385 (comment), it's an intermittent error that can happen on main today (I didn't chase down history for where it was introduced)

@mhaack

mhaack commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

@hannessolo @shsteimer the failing test is fixed now with the suggestion from @shsteimer .

@mhaack
mhaack merged commit 84ec18c into main Sep 30, 2026
7 checks passed
@mhaack
mhaack deleted the release branch September 30, 2026 09:43
@adobe-bot

Copy link
Copy Markdown

🎉 This PR is included in version 1.0.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

This branch was successfully deployed

1 active deployment
release — 01956383 Deployed Sep 30, 2026 by aem-code-sync[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants