Repository navigation
MWPW-209096 - Hide Cancel button when 100% uploaded during Acrobat redirect - #916
Closed
DavidKHahn wants to merge 1 commit into
Closed
DavidKHahn wants to merge 1 commit into
DavidKHahn wants to merge 1 commit into
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
Per design, hide the splash-screen Cancel button when continueInApp begins (progress bar jumps to 100% and the redirect to Acrobat is committed, so Cancel can no longer stop it). The button is restored whenever the splash screen is shown or hidden again. Follow-up to MWPW-206368. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DavidKHahn
force-pushed
the
hide-cancel-at-100
branch
from
September 28, 2026 23:40
425014c to
f1de532
Compare
DavidKHahn
changed the title
DavidKHahn
marked this pull request as ready for review
September 29, 2026 04:37
DavidKHahn
changed the title
DavidKHahn
requested review from
KetakiD-Deshwandikar,
Ruchika4,
markovicpredrag1209 and
maxn-adobe
September 29, 2026 04:41
Collaborator
Author
|
Superseded by #917 (branch renamed to |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #902 (MWPW-206368). Jira: https://jira.corp.adobe.com/browse/MWPW-209096
Once the upload finishes and the progress bar jumps to 100%, Unity has already committed the redirect to Acrobat, so clicking Cancel at that point can't stop it — users see Cancel "not work". Per design, hide the Cancel button from that moment.
transition-screen.js: newtoggleCancelButton(visible);splashVisibilityController()always restores the button so it's visible on the next upload.action-binder.jscontinueInApp(): hide Cancel as soon as the redirect is committed (before the bar fills to 100%).Test plan
toggleCancelButtonhide/show/no-button, restore on splash show/hide,continueInApphides Cancel before filling the bar (action-binder 252/252)stage)QA
Same Requestly setup as #902, but redirect to this branch:
/^https://www\.stage\.adobe\.com/unitylibs/(.*)/https://hide-cancel-at-100--unity--adobecom.aem.live/unitylibs/$1Steps (fresh incognito, signed out) on https://www.stage.adobe.com/acrobat/online/pdf-to-word.html: