Repository navigation
Conversation
ESPHome 2026.10 returns NDEF records as a StaticVector of unique_ptr, which cannot be copied. Bind get_records() by reference instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bachp
approved these changes
Oct 25, 2026
bachp
left a comment
bachp
left a comment
There was a problem hiding this comment.
I can confirm this fixes the issue with 2026.10
|
Thanks for the fantastic library! It would be great if this could be merged so we could continue to use it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since ESPHome 2026.10.0 the tag reader fails to compile:
NdefMessage::get_records()now returns aStaticVectorofstd::unique_ptr<NdefRecord>, which is non-copyable, soauto records = ...no longer compiles. This binds it by reference instead (auto &records). The loop body is unchanged.Tested: builds and runs on a D1 mini (ESP8266) with ESPHome 2026.10.0.
🤖 Generated with Claude Code