fix(appstream): isolate CI env vars in resolver tests - #157
Merged
Conversation
abn
force-pushed
the
fix_main_ci_failure
branch
from
August 23, 2026 20:31
cf4862a to
22e3cdd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root Cause
During tag/release workflow runs, CI environment variables like
GITHUB_REF(refs/tags/v0.33.0),GITHUB_REF_TYPE, andGITHUB_REF_NAMEare populated in the runner's ambient environment. Becausepkg/appstream/resolver_test.godid not isolate CI environment variables,TestResolveRelease_GitMockmatched the ambient CI environment variable branch before reaching the mocked Git command branch, failing the assertions.Solution
clearCIEnv) usingt.Setenvinpkg/appstream/resolver_test.gofor all tests.pkg/appstream/resolver.goto retainrawGitTagwhen matching CI tag environment variables so commit dates can also be extracted via Git log when available.