Repository navigation
Show coverage in the CI job summary instead of Codecov - #48
Merged
Merged
Conversation
The Codecov upload never worked: every upload was rejected with "Token required - not valid tokenless upload", and since the step had fail_ci_if_error: false nobody noticed. The badge stayed grey. - Remove the Codecov upload step and the README badge - check-coverage.sh also reports line and branch coverage and writes a table to the GitHub job summary - Update the workflow and testing docs - Use a plain dash in the README tagline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The codecov badge on the front page has always been grey. Every upload was rejected by Codecov with `Token required - not valid tokenless upload`, and since the step ran with `fail_ci_if_error: false` it never showed up as a failure.
Rather than wiring up a Codecov account and token, this drops Codecov and keeps everything inside GitHub:
Current numbers: 49% instructions, 49% lines, 38% branches. More tests follow in a separate PR.