Repository navigation
Remove the OpenFireMap overlay provider - #54
Merged
Merged
Conversation
OpenFireMap has moved to vector tiles and no longer serves the raster hytiles layer: every tile answers 404, over http and https alike. So PredefinedTileProviders.openFireMap() could only ever show nothing. - Remove openFireMap() and its test case - Drop it from the overlay list in MAP_TYPES.md - Point the class KDoc to MAP_TYPES.md instead of the missing TILE_OVERLAYS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #51
Switching the URL to https turned out not to be enough. OpenFireMap rebuilt its site on vector data (PMTiles plus Overpass queries), and the old raster endpoint
openfiremap.org/hytiles/{z}/{x}/{y}.pngnow returns 404 for every tile, at any zoom and over http and https. There is no raster layer left to point at, soPredefinedTileProviders.openFireMap()is removed.This is a breaking API change, but the method couldn't show anything anyway, and we're still on 0.x.
Also fixed the class KDoc, which pointed to a
docs/TILE_OVERLAYS.mdthat doesn't exist.