Repository navigation
Share one HTTP client between all UrlTileProviders - #55
Merged
Merged
Conversation
Every UrlTileProvider built its own Ktor client and the library never closed it. PredefinedTileProviders returns a new provider on each call, so switching overlays on and off kept adding clients. - All UrlTileProvider instances now use one lazily created client - close() is deprecated and does nothing, so existing callers still compile but can't close the client for everybody else - Tests check that providers share the client and that close() keeps it open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #53
Each
UrlTileProvidercreated its own KtorHttpClient, and nothing in the library closed it. SincePredefinedTileProvidershands out a new provider on every call, toggling overlays (as in Example09) kept piling up clients with their own connection pools.Now all providers share one lazily created client, which lives as long as the process.
close()is still there so existing code compiles, but it's deprecated and does nothing. Otherwise one caller could close the client for all the others.Two new tests check that providers share the client and that
close()leaves it open.