Repository navigation
Load Stamen tiles from Stadia Maps with an API key - #56
Merged
Merged
Conversation
- Add a "stadia" provider to ApiKeyManager (manifest key STADIA_API_KEY) - STAMEN_TONER and STAMEN_WATERCOLOR send the key and show the usual "API key required" overlay when it is missing - Move stamenTonerHybrid() and stamenTerrainLines() from the shut down Stamen server to the Stadia lines styles - Update MAP_TYPES.md, the MapType KDoc and Example11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #52
Stadia answers 401 without a key, and the old Stamen server used by the two overlays is gone (503).
ApiKeyManager, set with thede.afarber.openmapview.STADIA_API_KEYmeta-data orApiKeyManager.setApiKey("stadia", ...)STAMEN_TONERandSTAMEN_WATERCOLORnow require that key. Without it, the standard map shows with the "API key required" overlay, like for Thunderforest and TracestrackstamenTonerHybrid()andstamenTerrainLines()now loadstamen_toner_linesandstamen_terrain_linesfrom Stadia. The key is read for every tile, so it also works when it is set after the provider was created. Stadia has no combined hybrid style anymore, so the toner overlay shows lines only, without labelsTests: new Stadia cases in
TileSourceTestandPredefinedTileProvidersTest, 461 tests pass, coverage stays at 81%.