Skip to content

chore(deps): update runtime dependencies for odiff 4 - #198

Merged
cjber merged 3 commits into
mainfrom
cb/release-deps
Nov 16, 2026
Merged

cjber merged 3 commits into
mainfrom
cb/release-deps

Conversation

@cjber

@cjber cjber commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Updates the runtime dependencies before the next release.

  • @modelcontextprotocol/sdk 1.30.1 to 1.32.2
  • playwright 1.64.1 to 1.65.1
  • yaml floor raised to 2.9.1 (already locked there)
  • odiff-bin 3.2.1 to 4.5.0
  • pixelmatch 6.0.0 to 7.2.0

odiff 4 broke two things the unit tests did not cover:

  • An empty ignore-region list now fails with Invalid ignore regions format, so every unmasked diff threw. ignoreRegions is now passed only when there are masks.
  • A pixel diff whose output image cannot be written fails with Failed to save diff output, so the /dev/null sink broke every diff without diffOutPath. The unwanted image now goes to a scratch directory that is removed afterwards.

A new test runs the real odiff binary with and without a mask.

Left as is: pngjs, zod and esbuild are current. pixelmatch 8 is held back: it switches to an OKLab HyAB colour distance while odiff keeps YIQ, and the cross-check relies on both engines sharing one metric (Codex review comment). Dev tooling majors (typescript 7, vitest 5, @types/node 26) are not runtime dependencies and are out of scope for this release.

Local checks: pnpm check, pnpm knip, pnpm build, the bundle build and --version, and the packages/diff tests pass. Browser tests need Playwright's 1.65 Chromium, so CI runs them.

Independent Codex review (kiln) found one issue, fixed in the second commit: odiff 4 moves its binary into an optional platform package, and its "could not find the odiff binary" error did not trigger the pixelmatch fallback. It now does, verified by forcing the platform package lookup to fail.

🤖 Generated with Claude Code

Update the MCP SDK to 1.32.2, Playwright to 1.65.1, yaml to 2.9.1,
odiff-bin to 4.5.0 and pixelmatch to 8.0.0.

odiff 4 rejects an empty ignore-region list and fails a pixel diff it
cannot write, so pass ignoreRegions only when there are masks and send an
unwanted diff image to a scratch file instead of /dev/null. A real odiff
test covers both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
bugpatrol Skipped Skipped Nov 16, 2026 3:12pm UTC

Request Review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T15:00:22.952139Z a86d599 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@socket-security

socket-security Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedplaywright@​1.64.1 ⏵ 1.65.1100 +1100100 +19980
Updatedodiff-bin@​3.2.1 ⏵ 4.5.099 +9100100 +3587 -7100
Updatedpixelmatch@​6.0.0 ⏵ 8.0.010010010091100
Updated@​modelcontextprotocol/​sdk@​1.30.1 ⏵ 1.32.299 +1100 +3110096100

View full report

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Bugpatrol review: fixture-app

No problem introduced · tested bef9356 against main 7fa956c

Tested

  • Home (index.html) loads
  • Settings page loads

Not tested

  • The rest of the change: outside the fixture app

Updated on each push. Tests only what the diff can affect. Does not block the merge.

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Bugpatrol review: dashboard

No problem introduced · tested bef9356 against main 7fa956c

Tested

  • Overview page loads with status cards, needs-attention list, and live feed
  • Issue detail 'Save button overlaps account text' loads with judge reasoning, proposed fix, diff

Not tested

  • The rest of the change (dependency bumps, odiff.ts diff engine): Outside the dashboard: not rendered or run by the dashboard
  • Other dashboard pages (Coverage, Reviews, Activity, Flow, Screens, Memory): No changed file affects what these pages render

Updated on each push. Tests only what the diff can affect. Does not block the merge.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a86d599bf1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/diff/package.json Outdated
"odiff-bin": "^3.2.1",
"pixelmatch": "^6.0.0",
"odiff-bin": "^4.5.0",
"pixelmatch": "^8.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the cross-check on a shared color metric

When req.threshold is nonzero—packages/agents/src/evaluate.ts passes 0.1—this upgrade makes pixelmatch use OKLab/HyAB while odiff continues using YIQ. The pixelmatch 8 release notes explicitly warn that tuned thresholds and diff counts can change, but diff() still treats a count delta above four as evidence of a bad capture and assumes the pixelmatch fallback produces the same verdict. This therefore creates spurious engine-disagreement reports and host-dependent visual results whenever odiff is unavailable; retain a YIQ-based pixelmatch version or update the cross-check and fallback semantics before upgrading.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Valid. Fixed in the latest commit: pixelmatch is now held at ^7.2.0, the newest release that still uses the YIQ metric odiff uses, so the cross-check and the fallback keep one colour distance. The PR body records why 8 is left.

odiff 4 ships its binary in an optional platform package and throws
"could not find the odiff binary" when it is absent. Treat that as an
unavailable engine so the comparison falls back to pixelmatch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Bugpatrol review: cli

No problem introduced · tested bef9356 against main 7fa956c

Tested

  • CLI boots: --version and --help with bumped deps
  • issue list and issue show in the fixture workspace
  • memory list
  • odiff tests incl. new real-binary test (unmasked, masked, missing-platform-package msg)
  • pixelmatch 7 engine tests
  • diffWithOdiff built: unmasked/masked/empty-mask/fractional mask/diffOutPath/identical/scratch cleanup
  • diff() odiff-to-pixelmatch cross-check via built package

Not tested

  • replay open-home (browser routine): Needs fixture app serving on port 4311; guide forbids starting it. Failure is ERR_CONNECTION_REFUSED from the missing app, not the PR
  • capture and MCP SDK 1.32 runtime paths: No fixture app running to capture from; SDK is a transitive bump with no API change any CLI command exercises

Updated on each push. Tests only what the diff can affect. Does not block the merge.

pixelmatch 8 moves to an OKLab HyAB distance while odiff still uses YIQ,
so the cross-check would report engine disagreements on thresholds tuned
for YIQ. 7.2.0 is the newest release on the shared metric.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cjber
cjber merged commit a228555 into main Nov 16, 2026
12 checks passed

This branch was previously deployed

1 inactive deployment
Preview — bef93560 Deployed Nov 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant