Repository navigation
fix(doctor): add --gate so a gate-only config needs no model key - #201
Conversation
`bugpatrol init --gate` writes a config for the deterministic web gate and then suggested `bugpatrol doctor`, which failed with exit 2 because it checked the explorer and judge LLMs, which the gate never calls. `bugpatrol doctor --gate` now checks only what `bugpatrol run` needs: it leaves out the agent LLMs and gh, and fails when the config has no run block. `init --gate` suggests it, and unknown doctor flags are rejected. Closes #199 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bugpatrol review: fixture-appNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
Bugpatrol review: dashboardNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 434ad181a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
`doctor --gate` still ran the connect.url and platform checks of the app block, which only the agent commands use. A config whose agents target another URL failed the gate check when that URL was down, although `bugpatrol run` starts and drives run.url only. Under --gate, doctor now checks the config, Node, Chromium and the gate checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Codex review (session codex:01a1e520-2b19-7390-8534-66f218e5d9b5) reported one finding:
Fixed in 957e010: under |
Bugpatrol review: cliNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
|
Merged as 028357c. |
Summary
bugpatrol init --gatewrites a config for the deterministic web gate (bugpatrol run), then told the user to runbugpatrol doctor. Doctor checked every config for the explorer and judge LLMs with fatal checks, so withoutOPENROUTER_API_KEYit exited 2, although the gate never calls an agent.Design: an explicit flag,
bugpatrol doctor --gate, rather than inferring intent from the config. A config with arunblock can also drive the agents, so the config alone does not say which commands the user runs; the command does. With--gate, doctor checks only whatbugpatrol runneeds:gh, and the checks of theappblock (connect.url,python3, desktop tools), which only the agent commands userunblock, since the gate cannot start the app without oneinit --gatenow suggestsbugpatrol doctor --gate. Doctor also rejects unknown flags now, the wayrundoes, so a mistyped--gtaefails instead of running the full check. Plainbugpatrol doctorbehaves as before. The command reference, usage text and the deterministic gate guide document the flag.Test plan
vitest runondoctor.test.ts,doctor-gate.review.test.ts,init.test.ts: new tests cover a gate config with no key passing under--gate(and still failing without it),--gateon a config with no run block failing, a gate config whoseapp.connect.urlis down still passing, and flag parsingbiome check --error-on-warnings,tsc -p packages/cli,knipexamples/fixture-appwith noOPENROUTER_API_KEY:bugpatrol doctor --gateexits 0;doctor --gtaeexits 2 with "Unknown flag"Closes #199
🤖 Generated with Claude Code