Repository navigation
Conversation
…outines
A routine recorded on a fresh account replayed the literal values the
explorer typed, such as a new username. On the next fresh account that
value was taken, so the next step found no target and retests ended
unclear.
Every Vars now declares UNIQUE: 12 random lowercase hex characters, new
for each start of the app. The explorer is told to type it where a value
must be new on each run. Like a secret, it is redacted to its placeholder
in what the explorer sees, so routines record {{UNIQUE}} and a replay in a
new session types a new value, while the routines it requires share it.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugpatrol review: fixture-appNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
Bugpatrol review: dashboardNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43149475ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| this.values.set(UNIQUE, randomUUID().replaceAll('-', '').slice(0, 12)); | ||
| for (const name of secrets) { | ||
| if (env[name] !== undefined) { | ||
| this.set(name, env[name]); |
There was a problem hiding this comment.
Reserve the built-in UNIQUE name
When an existing configuration declares app.secrets: [UNIQUE] and that environment variable is set, the following loop overwrites this generated value with the fixed environment value; setup or proxy captures named UNIQUE can overwrite it later in the same way. Such sessions therefore reuse the value across app starts, defeating fresh-account routines while the prompt still describes it as per-session. Reject UNIQUE as a user-defined variable name or prevent these paths from replacing the built-in value.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Fixed in 1706780: the config rejects a setup capture named UNIQUE, and Vars.set refuses the name, so a secret or proxy named UNIQUE fails at startup instead of replacing the per-session value. Tests in packages/core/src/config/load.test.ts and packages/agents/src/vars.test.ts.
|
Codex review (session codex:01a1e535-7b63-7f61-a744-074699e66465) of the diff against origin/main: no correctness, security or contract regressions found. It read the Vars, lifecycle, patrol, explorer tool, retest and bench paths and ran the focused tests. No changes were needed. |
Bugpatrol review: cliNo problem introduced · tested Tested
Not tested
Updated on each push. Tests only what the diff can affect. Does not block the merge. |
A secret, setup capture or proxy named UNIQUE replaced the per-session
value with a fixed one, so fresh-account routines reused it. The config
now rejects a setup capture of that name, and Vars refuses to set it.
The Electron example guide still typed {{RUN_TAG}}, whose capture was
removed; it now types bugpatrol{{UNIQUE}}.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The UNIQUE constant was declared between appCommandSchema and its doc comment, so editors showed that comment on UNIQUE instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Closing as superseded by #200 from @joaquim-verges, which fixes #197 more completely: besides the per-run placeholder ( |
Summary
Routines recorded under a fresh-account profile replayed the literal values the explorer typed, such as the username
bugpatrolnew77. On the next fresh account that value is already taken, so a later step finds no target and the retest ends unclear.The value is now marked as per-run when it is typed, not guessed afterwards:
Vars(one per start of the app) declares{{UNIQUE}}: 12 random lowercase hex characters.typetool tell the explorer to put{{UNIQUE}}in a value that must be new on each run, such asbugpatrol{{UNIQUE}}.{{UNIQUE}}in what the explorer sees, so a routine records the placeholder. A replay in a new session expands it to a new value, and the routines it requires, replayed in the same session, share it. Setup commands get it asUNIQUEtoo.UNIQUEis reserved: the config rejects a setup capture of that name, andVarsrefuses to set it, so a secret or proxy cannot replace the per-session value.docs/configuration.mdexplains it; the getting-started onboarding example uses it instead of a setup capture, and the Electron example drops itsRUN_TAGcapture and its guide typesbugpatrol{{UNIQUE}}.No value is classified by its content: a value the explorer made up without the placeholder is still recorded as typed.
Follow-up outside this repo
Routines already recorded with literal values must be re-recorded. For nebula-desktop,
.bugpatrol/onboarding-instructions.mdshould say to type the username asbugpatrolnew{{UNIQUE}}instead of "bugpatrolnewplus a few digits", then the onboarding routines re-recorded.Open question
The issue also suggests re-recording a required routine automatically when its replay finds no target. That changes retest behaviour (a model run inside a retest, cost and determinism), so it needs a product decision and is not in this PR.
Test plan
vars.test.ts: eachVarsgets its own value, it resolves inside a word, and it is redacted to{{UNIQUE}}.agents-flow.test.ts: the explorer typesbugpatrol{{UNIQUE}}, the saved routine holds the placeholder, and a replay in a new session types a different value. Fails before the fix.load.test.tsandvars.test.ts: a capture, secret or set namedUNIQUEis refused.tsc --build.Refs #197: the recording side is fixed here, the nebula-desktop guide and its recorded routines still need updating, and automatic re-recording is open.
🤖 Generated with Claude Code