Skip to content

fix(deps): clear critical proxy-addr + high findings in sparc2 and mcp-hello lockfiles - #36

Merged
ruvnet merged 1 commit into
mainfrom
fix/sparc2-lockfile-audit
Nov 11, 2026
Merged

ruvnet merged 1 commit into
mainfrom
fix/sparc2-lockfile-audit

Conversation

@ruvnet

@ruvnet ruvnet commented Nov 11, 2026

Copy link
Copy Markdown
Contributor

What

npm audit on a fresh clone of main (c0306e7) — all 4 package-lock.json files:

dir before (all / --omit=dev) after
. 0 / 0 unchanged
scripts/agentic-mcp 7 low / 0 unchanged
scripts/sparc2 1 critical, 5 high, 2 moderate 0
scripts/agents/mcp-hello 1 critical, 5 high, 2 moderate 0

Findings: proxy-addr ≤2.0.7 (critical, IPv4-mapped IPv6 trust-subnet spoofing), @modelcontextprotocol/sdk ≤1.31.0, body-parser 2.0–2.3, path-to-regexp 8.0–8.3, zod <4.6.6, zod-to-json-schema ≤3.24.6 (high), express/qs (moderate) — all via the MCP SDK.

Fix: raise @modelcontextprotocol/sdk floor to ^1.32.2 in both manifests and refresh lockfiles (proxy-addr 2.0.8, path-to-regexp 8.4.2, body-parser 2.4.0, qs 6.17.1, zod 4.6.7, zod-to-json-schema 3.25.2). Both dirs added to the npm-audit CI matrix (#35).

Verified locally

  • mcp-hello: npm ci --ignore-scripts, npm run build (tsc) OK, stdio initialize + tools/list returns the greet tool on SDK 1.32.2.
  • sparc2: npm ci --ignore-scripts, Node ESM import smoke of the exact SDK surface sparc2-mcp-wrapper.js uses (Server, StdioServerTransport, ErrorCode, McpError, CallToolRequestSchema, ListToolsRequestSchema + setRequestHandler) OK; node --check sparc2-mcp-wrapper.js OK. The sparc2 Deno suite (deno test) was not run (no Deno on the runner box).

Not changed / residual

  • scripts/sparc2/deno.lock still pins npm:@modelcontextprotocol/sdk resolved with proxy-addr 2.0.7, path-to-regexp 8.2.0, zod 3.24.2. It only affects running sparc2 from this repo via Deno; it is not in the published files. Needs deno cache --reload by someone with Deno.
  • No release: published @agentics.org/sparc2@2.0.25 declares ^1.8.0, ships no shrinkwrap; a fresh install resolves SDK 1.32.2 and audits at 0. (Repo package.json is 2.0.22, behind the registry.) mcp-hello is not published.

🤖 Generated with claude-flow

…p-hello lockfiles

Raise @modelcontextprotocol/sdk floor to ^1.32.2 and refresh lockfiles:
proxy-addr 2.0.8, path-to-regexp 8.4.2, body-parser 2.4.0, qs 6.17.1,
zod 4.6.7, zod-to-json-schema 3.25.2. npm audit: 8 -> 0 in both dirs.
Add both dirs to the npm-audit CI matrix.

Co-Authored-By: claude-flow <ruv@ruv.net>
@ruvnet
ruvnet merged commit e5ccf78 into main Nov 11, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant