Repository navigation
fix(deps): clear critical proxy-addr + high findings in sparc2 and mcp-hello lockfiles - #36
Merged
Merged
Conversation
…p-hello lockfiles Raise @modelcontextprotocol/sdk floor to ^1.32.2 and refresh lockfiles: proxy-addr 2.0.8, path-to-regexp 8.4.2, body-parser 2.4.0, qs 6.17.1, zod 4.6.7, zod-to-json-schema 3.25.2. npm audit: 8 -> 0 in both dirs. Add both dirs to the npm-audit CI matrix. Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
npm auditon a fresh clone of main (c0306e7) — all 4package-lock.jsonfiles:.scripts/agentic-mcpscripts/sparc2scripts/agents/mcp-helloFindings: proxy-addr ≤2.0.7 (critical, IPv4-mapped IPv6 trust-subnet spoofing), @modelcontextprotocol/sdk ≤1.31.0, body-parser 2.0–2.3, path-to-regexp 8.0–8.3, zod <4.6.6, zod-to-json-schema ≤3.24.6 (high), express/qs (moderate) — all via the MCP SDK.
Fix: raise
@modelcontextprotocol/sdkfloor to^1.32.2in both manifests and refresh lockfiles (proxy-addr 2.0.8, path-to-regexp 8.4.2, body-parser 2.4.0, qs 6.17.1, zod 4.6.7, zod-to-json-schema 3.25.2). Both dirs added to thenpm-auditCI matrix (#35).Verified locally
npm ci --ignore-scripts,npm run build(tsc) OK, stdioinitialize+tools/listreturns thegreettool on SDK 1.32.2.npm ci --ignore-scripts, Node ESM import smoke of the exact SDK surfacesparc2-mcp-wrapper.jsuses (Server, StdioServerTransport, ErrorCode, McpError, CallToolRequestSchema, ListToolsRequestSchema + setRequestHandler) OK;node --check sparc2-mcp-wrapper.jsOK. The sparc2 Deno suite (deno test) was not run (no Deno on the runner box).Not changed / residual
scripts/sparc2/deno.lockstill pins npm:@modelcontextprotocol/sdk resolved with proxy-addr 2.0.7, path-to-regexp 8.2.0, zod 3.24.2. It only affects running sparc2 from this repo via Deno; it is not in the publishedfiles. Needsdeno cache --reloadby someone with Deno.@agentics.org/sparc2@2.0.25declares^1.8.0, ships no shrinkwrap; a fresh install resolves SDK 1.32.2 and audits at 0. (Repo package.json is 2.0.22, behind the registry.) mcp-hello is not published.🤖 Generated with claude-flow