Skip to content

Complete products API endpoint and improve error handling - #15

Merged
ahcodedev merged 1 commit into
mainfrom
prices-api-products-1
Nov 10, 2026
Merged

ahcodedev merged 1 commit into
mainfrom
prices-api-products-1

Conversation

@ahcodedev

@ahcodedev ahcodedev commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

Implements products (GET /api/products) on both clients and simplifies the route definitions.

  • products(q): returns a ProductsResponse with up to 20 matches. q is stripped; an empty query raises ParameterError before any request is sent.
  • Routes: Route is now a plain class with nested StrEnums (Route.Prices, Route.Marketplace), so paths are passed without .value. The top-level Prices and MarketPlace enums are gone, and MarketPlace is renamed Marketplace.
  • OfferPublishRequest: the missing-identifier message now ends in "is required".
  • Docs: new "Searching products" section, updated status lines in README.md and docs/index.md, and shorter docstrings and docs wording throughout.
  • Tests: products tests for both clients replace the placeholders; route tests updated for the new structure.

Related Issues

None

Type of Change

feature: new endpoint. pypricecharting.route.Prices and MarketPlace are no longer importable; use Route.Prices and Route.Marketplace.

Checklist

  • just lint passes
  • just test passes
  • Tests added or updated for the change
  • Docs updated if needed (README.md, docs/, CLAUDE.md)
  • Release label added

@ahcodedev ahcodedev added the feature New feature (minor version bump) label Nov 10, 2026
@ahcodedev
ahcodedev merged commit 9e3ca62 into main Nov 10, 2026
11 checks passed
@ahcodedev
ahcodedev deleted the prices-api-products-1 branch November 10, 2026 05:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature (minor version bump)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant