Repository navigation
Complete products API endpoint and improve error handling - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
products(GET /api/products) on both clients and simplifies the route definitions.products(q): returns aProductsResponsewith up to 20 matches.qis stripped; an empty query raisesParameterErrorbefore any request is sent.Routeis now a plain class with nestedStrEnums (Route.Prices,Route.Marketplace), so paths are passed without.value. The top-levelPricesandMarketPlaceenums are gone, andMarketPlaceis renamedMarketplace.OfferPublishRequest: the missing-identifier message now ends in "is required".README.mdanddocs/index.md, and shorter docstrings and docs wording throughout.productstests for both clients replace the placeholders; route tests updated for the new structure.Related Issues
None
Type of Change
feature: new endpoint.pypricecharting.route.PricesandMarketPlaceare no longer importable; useRoute.PricesandRoute.Marketplace.Checklist
just lintpassesjust testpassesREADME.md,docs/,CLAUDE.md)