Skip to content

Marketplace Offers API Endpoint - #16

Merged
ahcodedev merged 3 commits into
mainfrom
marketplace-offers
Nov 10, 2026
Merged

ahcodedev merged 3 commits into
mainfrom
marketplace-offers

Conversation

@ahcodedev

@ahcodedev ahcodedev commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

Implements offers (GET /api/offers) on both clients, with typed request parameters, and restructures the condition enums.

  • offers(params): takes an OffersRequestParams and returns an OffersResponse. Only status is required; unset filters are not sent.
  • New request types: OffersRequestParams, OffersStatus and OffersSort, exported from pypricecharting.
  • Condition: now a plain class holding one IntEnum per category (Condition.VideoGames, Condition.Cards, Condition.Comics, Condition.Coins).
  • Genre and Console: now StrEnums.
  • Docs: new "Listing offers" section in docs/index.md; status lines updated there and in README.md.
  • Tests: offers tests for both clients replace the placeholders, plus tests for the new request types. Offer test data uses a placeholder offer ID.

Related Issues

None

Type of Change

feature and refactor. See the breaking changes above when choosing the release label.

Checklist

  • just lint passes
  • just test passes
  • Tests added or updated for the change
  • Docs updated if needed (README.md, docs/, CLAUDE.md)
  • Release label added

@ahcodedev ahcodedev added feature New feature (minor version bump) refactor Refactor with no behavior change (patch version bump) labels Nov 10, 2026
@ahcodedev ahcodedev changed the title Marketplace offers Marketplace Offers API Endpoint Nov 10, 2026
@ahcodedev
ahcodedev merged commit c31a764 into main Nov 10, 2026
14 checks passed
@ahcodedev
ahcodedev deleted the marketplace-offers branch November 10, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature (minor version bump) refactor Refactor with no behavior change (patch version bump)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant