Repository navigation
Marketplace Offers API Endpoint - #16
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements
offers(GET /api/offers) on both clients, with typed request parameters, and restructures the condition enums.offers(params): takes anOffersRequestParamsand returns anOffersResponse. Onlystatusis required; unset filters are not sent.OffersRequestParams,OffersStatusandOffersSort, exported frompypricecharting.Condition: now a plain class holding oneIntEnumper category (Condition.VideoGames,Condition.Cards,Condition.Comics,Condition.Coins).GenreandConsole: nowStrEnums.docs/index.md; status lines updated there and inREADME.md.offerstests for both clients replace the placeholders, plus tests for the new request types. Offer test data uses a placeholder offer ID.Related Issues
None
Type of Change
featureandrefactor. See the breaking changes above when choosing the release label.Checklist
just lintpassesjust testpassesREADME.md,docs/,CLAUDE.md)