Skip to content

Marketplace API - Offer Details endpoint - #17

Merged
ahcodedev merged 1 commit into
mainfrom
marketplace-offer-details
Nov 10, 2026
Merged

ahcodedev merged 1 commit into
mainfrom
marketplace-offer-details

Conversation

@ahcodedev

@ahcodedev ahcodedev commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

Implements the Marketplace offer_details method in both clients, replacing the stub.

  • PriceCharting.offer_details(offer_id) and AsyncPriceCharting.offer_details(offer_id) send a GET to /api/offer-details with offer-id and return an OfferDetailsResponse.
  • offer_id is stripped, and an empty or whitespace-only value raises ParameterError before any request is sent, the same way products(q) handles q.
  • The placeholder test is replaced by four tests per client: success, whitespace stripping, empty offer ID, and API error.
  • Docs: a new "Offer details" section in docs/index.md, and the implementation status line in README.md and the docs index now lists offer_details.

Type of Change

Feature

Checklist

  • just lint passes
  • just test passes
  • Tests added or updated for the change
  • Docs updated if needed (README.md, docs/, CLAUDE.md)
  • Release label added

@ahcodedev ahcodedev added the feature New feature (minor version bump) label Nov 10, 2026
@ahcodedev
ahcodedev merged commit 6eb1de9 into main Nov 10, 2026
11 checks passed
@ahcodedev
ahcodedev deleted the marketplace-offer-details branch November 10, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature (minor version bump)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant