Skip to content

Marketplace API - Offer Feedback endpoint - #19

Merged
ahcodedev merged 1 commit into
mainfrom
marketplace-offer-feedback
Nov 10, 2026
Merged

ahcodedev merged 1 commit into
mainfrom
marketplace-offer-feedback

Conversation

@ahcodedev

@ahcodedev ahcodedev commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

Implements the Marketplace offer_feedback method in both clients, replacing the stub.

  • PriceCharting.offer_feedback(offer_id, rating, comment=None) and AsyncPriceCharting.offer_feedback(...) send a POST to /api/offer-feedback with offer-id, rating, and comment as form data and return an OfferFeedbackResponse.
  • The placeholder test is replaced by four tests per client: success, no comment, empty offer ID, and API error.
  • Docs: a new "Leaving feedback" section in docs/index.md, and the implementation status line in README.md and the docs index now lists offer_feedback. The client class docstrings now name the methods still unimplemented (offer_ship, offer_end, offer_refund).

Related Issues

None

Type of Change

Feature

Checklist

  • just lint passes
  • just test passes
  • Tests added or updated for the change
  • Docs updated if needed (README.md, docs/, CLAUDE.md)
  • Release label added

@ahcodedev ahcodedev added the feature New feature (minor version bump) label Nov 10, 2026
@ahcodedev
ahcodedev merged commit cb282c0 into main Nov 10, 2026
11 checks passed
@ahcodedev
ahcodedev deleted the marketplace-offer-feedback branch November 10, 2026 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature (minor version bump)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant