Skip to content

Marketplace API - Offer End and Offer Refund endpoints - #21

Merged
ahcodedev merged 2 commits into
mainfrom
marketplace-offer-end-refund
Nov 10, 2026
Merged

ahcodedev merged 2 commits into
mainfrom
marketplace-offer-end-refund

Conversation

@ahcodedev

@ahcodedev ahcodedev commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

Implements the last two Marketplace methods, offer_end and offer_refund and brings the models, specs, and docs in line with the API documentation. Both clients now have a method for every Prices API and Marketplace API operation.

  • offer_end(offer_id): sends a POST to /api/offer-end and returns an OfferEndResponse.
  • offer_refund(offer_id): sends a POST to /api/offer-refund and returns an OfferRefundResponse.
  • OfferDetailsResponse: max_price / min_price are renamed price_max / price_min (JSON keys price-max / price-min), after the documentation's key table. New optional fields: best_competing_price, value, is_best_priced_offer, pending_reason, image_url, and seller_id.
  • OfferPublishRequestParams: add_to_collection is now State | None instead of str | None, like the condition tags.
  • API reference: the OpenAPI spec and the Bruno offer-details request use the renamed price keys and list the new fields. Example values and the offer-publish identifier wording are aligned with the documentation.
  • Docs: new "Ending an offer" and "Refunding an offer" sections in docs/index.md. The "under development" status line is replaced in README.md and the docs index, and the client class docstrings no longer list unimplemented methods. README.md gains a "TODO / Investigate" section on what still needs checking against the live API. CI.md and RELEASE.md document the require-label check, the file-based auto labels, and the Release workflow's direct push to main.
  • Tests: the placeholder tests are replaced by three tests per method per client (success, empty offer ID, API error), plus tests for the add_to_collection type and the new OfferDetailsResponse fields.

Related Issues

None

Type of Change

Feature

Checklist

  • just lint passes
  • just test passes
  • Tests added or updated for the change
  • Docs updated if needed (README.md, docs/, CLAUDE.md)
  • Release label added

@ahcodedev ahcodedev added the feature New feature (minor version bump) label Nov 10, 2026
@ahcodedev
ahcodedev merged commit 21e20cc into main Nov 10, 2026
11 checks passed
@ahcodedev
ahcodedev deleted the marketplace-offer-end-refund branch November 10, 2026 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature (minor version bump)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant