Repository navigation
Marketplace API - Offer End and Offer Refund endpoints - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the last two Marketplace methods,
offer_endandoffer_refundand brings the models, specs, and docs in line with the API documentation. Both clients now have a method for every Prices API and Marketplace API operation.offer_end(offer_id): sends aPOSTto/api/offer-endand returns anOfferEndResponse.offer_refund(offer_id): sends aPOSTto/api/offer-refundand returns anOfferRefundResponse.OfferDetailsResponse:max_price/min_priceare renamedprice_max/price_min(JSON keysprice-max/price-min), after the documentation's key table. New optional fields:best_competing_price,value,is_best_priced_offer,pending_reason,image_url, andseller_id.OfferPublishRequestParams:add_to_collectionis nowState | Noneinstead ofstr | None, like the condition tags.offer-detailsrequest use the renamed price keys and list the new fields. Example values and theoffer-publishidentifier wording are aligned with the documentation.docs/index.md. The "under development" status line is replaced inREADME.mdand the docs index, and the client class docstrings no longer list unimplemented methods.README.mdgains a "TODO / Investigate" section on what still needs checking against the live API.CI.mdandRELEASE.mddocument therequire-labelcheck, the file-based auto labels, and the Release workflow's direct push tomain.add_to_collectiontype and the newOfferDetailsResponsefields.Related Issues
None
Type of Change
Feature
Checklist
just lintpassesjust testpassesREADME.md,docs/,CLAUDE.md)