Repository navigation
fix(mcp): adapt login consent cookie to fastmcp 4.1.7 - #1466
Draft
Ryan Waskewich (rwask) wants to merge 2 commits into
Draft
Ryan Waskewich (rwask) wants to merge 2 commits into
Ryan Waskewich (rwask) wants to merge 2 commits into
Conversation
Co-Authored-By: Ryan Waskewich <ryan.waskewich@airbyte.io>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1794496558-fix-mcp-login-consent-cookie' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1794496558-fix-mcp-login-consent-cookie'PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesCommunity SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
Contributor
Code coverage overviewLanguages: Python Python / code-coverage/pytest-no-creds
View coverage of the 10 most impacted files.
Python / code-coverage/pytest
View coverage of the 10 most impacted files.
Python / code-coverage/pytest-unit
Line coverage data for the release-candidate/v1 branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
Co-Authored-By: Ryan Waskewich <ryan.waskewich@airbyte.io>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The hosted Cloud MCP (
mcp.airbyte.com,1.0.0-rc.42) returns HTTP 500 on everyPOST /auth/login, so no new user can finish OAuth sign-in. Already-authenticated sessions are unaffected. Datadog shows ~518 failures since 2026-11-06 22:37 UTC:fastmcp4.1.7 dropped therequestparameter from the private_set_consent_binding_cookie. Ourfastmcp>=4.0.9,<5.0range let the prod image resolve 4.1.8, whileAirbyteSsoOidcProxy._redirect_upstreamstill passedrequest.Changes:
_redirect_upstream:self._set_consent_binding_cookie(response, txn.txn_id, consent_token)(norequest).fastmcpfloor raised to>=4.1.7,<5.0;uv.lockresolves 4.1.8.check_fastmcp_compatibility()now also checks the positional parameters of_set_consent_binding_cookie,_verify_consent_binding_cookieand_build_upstream_authorize_url, so future signature drift fails at startup instead of on each login./auth/login(default and SSO) asserts a 302 to the upstream with a transaction-bound consent cookie.Test plan:
pytest tests/unit_tests/test_mcp_sso_auth.py(130 passed),ruff check,pyrefly check. Not yet verified against prod; after release + redeploy, confirmPOST /auth/loginno longer returns 500 forservice:cloud-mcp.Requested by Ryan Waskewich (Ryan Waskewich (@rwask)).
Link to Devin session: https://app.devin.ai/sessions/aefbc0c0a8764137a0dc2a1a77d252aa
Open in Devin Desktop: https://app.devin.ai/desktop/session/aefbc0c0a8764137a0dc2a1a77d252aa?variant=devin