Repository navigation
feat(mcp): serve OpenAI apps domain verification token - #1470
Closed
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
Closed
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
Aaron ("AJ") Steers (aaronsteers) wants to merge 1 commit into
Conversation
Co-Authored-By: AJ Steers <aj@airbyte.io>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1794527305-openai-apps-challenge' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1794527305-openai-apps-challenge'PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesCommunity SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
Contributor
Code coverage overviewLanguages: Python Python / code-coverage/pytest-no-creds
View coverage of the 10 most impacted files.
Python / code-coverage/pytest
View coverage of the 10 most impacted files.
Python / code-coverage/pytest-unit
Line coverage data for the release-candidate/v1 branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Serves
GET /.well-known/openai-apps-challengeon the Cloud MCP HTTP server so OpenAI can verify themcp.airbyte.comdomain for the ChatGPT app submission. The route is a Starlettecustom_routenext to/health, outside MCP auth, and returns only the token astext/plain; charset=utf-8(no JSON, no trailing newline).The token sits in code as
OPENAI_APPS_CHALLENGEbecause OpenAI publishes it at a public URL anyway, so it isn't a secret. Putting it in an env var would also need an infra change to the Cloud Run deploy. Prod already sends the wholemcp.airbyte.comhost to this app (/healthreturns 200 there), so the route goes live with the next release.test_openai_apps_challenge_without_authchecks the exact bytes, content type and a 200 with noAuthorizationheader, both with auth off and with aJWTVerifieron. With the verifier on, it also checks that/mcpstill returns 401.Local run (
python -m airbyte.mcp.http_main):MCP Guru Devin - By AJ opened this PR for AJ
Implemented in session Serve OpenAI domain verification token on Cloud MCP
Review with Devin · Open in Devin Desktop