Repository navigation
feat(mcp): serve OpenAI Apps SDK domain-verification token from env - #1471
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This PyAirbyte VersionYou can test this version of PyAirbyte using the following: # Run PyAirbyte CLI from this branch:
uvx --from 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1794527890-openai-apps-challenge' pyairbyte --help
# Install PyAirbyte from this branch for development:
pip install 'git+https://github.com/airbytehq/PyAirbyte.git@devin/1794527890-openai-apps-challenge'PR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
📚 Show Repo GuidanceHelpful ResourcesCommunity SupportQuestions? Join the #pyairbyte channel in our Slack workspace. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Devin Review🟢 Devin Review found nothing to fix · View findings |
Code coverage overviewLanguages: Python Python / code-coverage/pytest-no-creds
View coverage of the 10 most impacted files.
Python / code-coverage/pytest
View coverage of the 10 most impacted files.
Python / code-coverage/pytest-unit
Line coverage data for the release-candidate/v1 branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
|
Codex (@codex) review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback". |
1a4ad47
into
release-candidate/v1
Summary
OpenAI's Apps SDK verifies ownership of an MCP server's host by fetching a token, as plain text, from
/.well-known/openai-apps-challenge. The hosted Airbyte MCP (mcp.airbyte.com) currently 404s there, blocking the Apps directory submission (Slack thread, AGENTIC-2419).This adds an env-driven route to the HTTP MCP server, next to
/health:monkeypatchand avoids import-order coupling.mcp.airbyte.comis set in the Cloud MCP deploy workflow in airbyte-platform-internal (companion PR).airbyte.mcpandairbyte.mcp.http_mainmodule docstrings.Tests
tests/unit_tests/test_mcp_http.py: configured token is returned verbatim (stripped) astext/plainwith 200; unset var yields 404.Requested by Caleb Evans (@calebevans-ab).
Link to Devin session: https://app.devin.ai/sessions/9215bf131c41438ba2c01d6b3277117a
Open in Devin Desktop: https://app.devin.ai/desktop/session/9215bf131c41438ba2c01d6b3277117a?variant=devin