Repository navigation
build: take gpui-fast e7aa5e17, which builds in release with tests - #8
Merged
Merged
Conversation
gpui-fast bb5991c named `Interactivity::debug_selector` in `fast/element.rs` under `test-support` alone, while the field exists only with debug assertions too, so any release build with GPUI's test-support failed: `cargo test --release -p gpui-base --lib --no-run` stopped with E0026. e7aa5e17 carries the field's own cfg, along with the value and state transitions and tooltips on keyboard focus. That command and `cargo build --release -p gpui-kit` now finish; `gpui-base` (1338) and `gpui-component` (601) lib tests pass, and gpui-component checks for aarch64-apple-ios-sim. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This bumps the kit's pinned gpui-fast from
bb5991cto fork maine7aa5e17. OnlyCargo.lockchanges, and the only dependency movement outside gpui-fast is fourwindows0.57 crates dropping out.The defect
At
bb5991c,fast/element.rsdestructuresInteractivity::debug_selectorunder#[cfg(any(test, feature = "test-support"))]. The field itself only exists underany(test, all(debug_assertions, feature = "test-support")). A release build that enables GPUI'stest-supportfeature, which includes everycargo test --release, therefore fails to compile.Proof, before the bump:
A plain
cargo build --release -p gpui-basedoes build atbb5991c. Only release builds withtest-supportare affected.After the bump
cargo test --release -p gpui-base --lib --no-runfinishes.cargo build --release -p gpui-kitfinishes.cargo test -p gpui-base -p gpui-component --lib: 1338 and 601 passed.cargo check -p gpui-component --target aarch64-apple-ios-simfinishes.cargo clippy --workspace --exclude gpui-shell -- --deny warningsfails locally (clippy 1.99) with 10too_many_arguments (7/6)errors ingpui-basefiles this PR does not touch. The lock bump cannot cause them, and main was not re-run to compare.e7aa5e17also bringsValueTransitionand tooltips on keyboard focus (gpui-fast longbridge#23 and longbridge#24).🤖 Generated with Claude Code