Retire custom install/uninstall scripts; make UV the supported path - #3
Merged
Merged
Conversation
…ly path. Remove install.sh, install.ps1, uninstall.sh, and uninstall.ps1. Users install and remove TempFox with uv tool install/uninstall (or uv sync / uv run from source). Runtime preflight still installs AWS CLI, Go, and CloudFox. Docs and a contract test lock the UV-first story. Co-authored-by: David Diaz <alfdav@users.noreply.github.com>
alfdav
marked this pull request as ready for review
August 15, 2026 23:33
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Approved. Cursor Bugbot was not present after the initial check poll, so that signal was skipped; remaining policy and review-state checks did not require human review. No reviewers were assigned.
Sent by Cursor Approval Agent: Pull Request Router and Approver
State that Go/CloudFox PATH is no longer persisted to the shell. Tell users to remove the script-era venv before uv tool install so they do not delete the UV shim. Tighten the install-path contract tests. Co-authored-by: David Diaz <alfdav@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stop maintaining
install.sh,install.ps1,uninstall.sh, anduninstall.ps1. TempFox is installed and removed with UV.Supported path
From source
pip install tempfoxremains a one-line alternative. No second package-manager story and no replacement installer.What the scripts did vs what remains
The four scripts were Hitmonlee-style wrappers that:
~/.local/share/tempfox/%LOCALAPPDATA%\tempfox) and a PATH wrapperMoved to UV
tempfoxon PATH (uv tool install/uv tool uninstall)uv sync/uv run tempfox)Already covered by runtime preflight (
tempfox/dependencies.py)Documented loss (not replaced)
tempfoxrun (first run preflight still does Go/CloudFox/AWS CLI)~/.local/share/tempfox(Unix) or%LOCALAPPDATA%\tempfox(Windows) beforeuv tool install, and not torm ~/.local/bin/tempfoxwhile a UV install is active (that path is the UV shim).uv.lock
Not added.
.gitignorealready ignoresuv.lock, CI runsuv sync(not--frozen), and Docker copiespyproject.tomlonly. Pinning a lockfile would invent a new workflow.Test plan
make hygiene-fastbaseline onmain(55 passed)tests/test_install_docs.pypasses (scripts gone, UV commands present, no script invocations, leftover cleanup before install, session-only PATH documented)make hygieneon this branch after review fixes: ruff, format, mypy, 60 passed, coverage 58.21% (>= 35), repo-scan cleaninstall.sh/install.ps1Files changed
install.sh,install.ps1,uninstall.sh,uninstall.ps1README.md,MIGRATION.md,docs/project-context.md,MISTAKES.mdtests/test_install_docs.pyDo not merge. This is a separate objective from recon-fixes.