Repository navigation
Accelerate BN254 input coefficient conversion - #179
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace generic integer conversion and bit export with specialized Montgomery decoding and fixed 52-bit chunk extraction on 64-bit-limb backends. Reuse Crypto3’s existing field helpers while preserving canonical coefficient values and the 32-bit-limb fallback.
Extend boundary tests to cover the stored Montgomery representation. Add a compile-only regression test ensuring the 32-bit fallback does not instantiate the 64-bit helper.
Measured x86 input-conversion CPU time, using medians of seven trials after two warmups:
Fp12 coefficients: Before, After, Speedup
2,048: 5.01 ms, 1.22 ms, 4.10×
14,938: 40.63 ms, 11.45 ms, 3.55×
These measurements cover input conversion only.