Repository navigation
polynomial cleanup - #186
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidate shared polynomial operations, organize backend-specific code, and remove unnecessary retention of processed factors while preserving existing public APIs and exact results.
• Split the small-prime backend into focused transform, conversion, CRT, and pointwise headers under polynomial/backends/detail/small_prime_fft/.
• Extract prepared coefficient-combination machinery from the generic modular-composition implementation.
• Share canonical-polynomial validation and in-place multiplication by X modulo a divisor across exponentiation, Frobenius, and square-root recovery.
• Add an internal factor-consumption path so norm recovery can process factors without retaining a duplicate factor history. Public factorization APIs continue collecting results, preserving factor order, multiplicities, callback stopping, and RNG behavior.
• Update documentation for backend selection, memory budgets, odd/even-degree recovery, ownership, and early stopping.
• Explicitly align SIMD debug buffers to resolve the GCC 15 sanitizer crash exposed during validation.