Repository navigation
fix(proxy): honour secure flag — reject secure=false, support HTTPS upstreams - #58
Merged
Merged
Conversation
Wire the proxy client to an HTTPS-capable connector and fail fast when a route opts out of certificate verification, which was never honoured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--proxy ...&secure=falsewas parsed and stored but never enforced — the proxy client only spoke plain HTTP viaHttpConnector, so TLS verification was effectively always on (and HTTPS targets could not be reached at all).Fix
hyper-rustlswith native roots, HTTP/1), so HTTPS upstreams actually work.secure=falseis now rejected at startup with a clear error instead of silently doing nothing — disabling certificate verification is not supported.Fixes #24