Repository navigation
fix(proxy): stream proxied response bodies instead of buffering - #59
Merged
Merged
Conversation
Use an io::Error body type so the upstream body can be passed through instead of being collected into memory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proxy_requestno longer collects the upstream response into memory. The server response body is nowBoxBody<Bytes, std::io::Error>, so the upstreamIncomingbody is passed straight through instead of being buffered.proxy_requeststreamsupstream_res.into_body()and maps upstream errors toio::Error.BoxBody<_, Infallible>usages in the http1 package and serve handler switched toio::Errorto match.body_streamno longer usespanic!()for reader errors; it maps them toio::Error.Fixes #23