Skip to content

Fix timestamp fractional precision in ion_equals #459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vera-rubin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix timestamp fractional precision in ion_equals #459

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src-python/amazon/ion/equivalence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ def _timestamps_eq(a, b):
if isinstance(b, Timestamp):
# Both operands declare their precisions. They are only equivalent if their precisions are the same.
if a.precision is b.precision and a.fractional_precision is b.fractional_precision \
and a.fractional_seconds == b.fractional_seconds:
and _decimals_eq(a.fractional_seconds, b.fractional_seconds):
break
return False
elif a.precision is not TimestampPrecision.SECOND or a.fractional_precision != MICROSECOND_PRECISION:
Expand Down
5 changes: 5 additions & 0 deletions tests/test_equivalence.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,11 @@ def _ion_nature(_ion_nature_cls, ion_type, value=None, annotations=()):
_ts(1999, 12, 31, 23, 59, off_hours=0, off_minutes=-1, precision=_TP.SECOND),
None,
),
(
# Timestamps with different fractional precisions beyond microseconds are not equivalent.
_timestamp(_ts(2000, precision=_TP.SECOND, fractional_seconds=Decimal('0.000000'))),
_timestamp(_ts(2000, precision=_TP.SECOND, fractional_seconds=Decimal('0.0000000'))),
),
(
# Timestamps with different fractional seconds are not equivalent.
_timestamp(_ts(2000, 1, 1, 1, precision=_TP.SECOND, fractional_seconds=Decimal('0.123456789'))),
Expand Down