Repository navigation
Conversation
With the deployment of the "kickd" varlink based backchannel to trigger updates by the ACP we no longer need the extremly aggressive 2min update timer. Instead this commit moves to a more reasonable 8h with a 30min spread. As side effect of the spread is that on boot the first update is also only checked after the spread. That is okay for now but we should have a mode that checks for updates first thing (even before servics come up) eventually. ENG-100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked until https://github.com/amutable/control-plane/pull/163 is merged - we could still merge it before but then any demo would have to press "u" in the TUI to force an update (the 2min timer is already quite long when demoing this).
With the deployment of the "kickd" varlink based backchannel to trigger updates by the ACP we no longer need the extremly aggressive 2min update timer. Instead this commit moves to a more reasonable 8h with a 30min spread. As side effect of the spread is that on boot the first update is also only checked after the spread. That is okay for now but we should have a mode that checks for updates first thing (even before servics come up) eventually.
ENG-100