Repository navigation
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
🤖 Pull request artifacts
|
capcom6
force-pushed
the
messages/created-at-field
branch
2 times, most recently
from
September 2, 2026 01:16
0d72867 to
c58b63b
Compare
capcom6
force-pushed
the
messages/created-at-field
branch
from
September 2, 2026 02:20
c58b63b to
bba39d4
Compare
|
This PR is stale because it has been open for 7 days with no activity. |
|
This PR is stale because it has been open for 7 days with no activity. |
capcom6
force-pushed
the
messages/created-at-field
branch
from
September 25, 2026 01:35
bba39d4 to
3faa1e8
Compare
capcom6
force-pushed
the
messages/created-at-field
branch
from
September 29, 2026 01:41
dc08171 to
4f0ed28
Compare
capcom6
force-pushed
the
messages/created-at-field
branch
from
September 30, 2026 05:28
d609a2c to
1b2fddc
Compare
capcom6
force-pushed
the
messages/created-at-field
branch
from
October 2, 2026 01:03
1b2fddc to
4a39a58
Compare
| MmsMessage: state.MmsContent, | ||
| HashedMessage: state.HashedContent, | ||
|
|
||
| ScheduleAt: nil, |
There was a problem hiding this comment.
The status schema now advertises scheduleAt, but this converter always sets it to nil. For scheduled messages, enqueue, status, and history responses omit the persisted delivery time, so API consumers cannot recover the schedule from the status response.
Knowledge Base Used:
Prompt To Fix With AI
This is a comment left during a code review.
Path: internal/sms-gateway/handlers/converters/messages.go
Line: 64
Comment:
**Scheduled time missing from status**
The status schema now advertises `scheduleAt`, but this converter always sets it to nil. For scheduled messages, enqueue, status, and history responses omit the persisted delivery time, so API consumers cannot recover the schedule from the status response.
**Knowledge Base Used:**
- [SMS message delivery lifecycle](https://app.greptile.com/smsgate-app/-/custom-context/knowledge-base/android-sms-gateway/server/-/docs/message-delivery-lifecycle.md)
- [API contracts and external integrations](https://app.greptile.com/smsgate-app/-/custom-context/knowledge-base/android-sms-gateway/server/-/docs/api-contracts-and-integrations.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.client-go 1.16.1 changed MobileUpdateRequest.PushToken to *string, and passing it straight through persisted an empty token on PATCH /mobile/v1/device. Event dispatch treats any non-nil token as a reason to push and skips the device SSE connection, so such a device stopped receiving enqueue and cancellation notifications. Normalize an empty value back to nil to preserve the pre-upgrade behavior.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR is not yet safe to merge because enqueue responses can still expose an invalid creation time on supported MySQL deployments and scheduled status responses still omit their delivery time.
Findings
Fix with agent prompt
Summary
The PR exposes message creation timestamps in status responses and updates the client contract and generated OpenAPI documentation. It also adjusts enqueue ordering and normalizes empty mobile push tokens.
createdAtto the message-state domain and API conversion.Reviews (13) · Last reviewed commit: "[mobile] keep empty push token from disa..." · Reviewed by Greptile