Repository navigation
docs(@angular/build): correct the unit-test browsers option description - #34589
Merged
alan-agius4 merged 1 commit intoOct 30, 2026
Merged
Conversation
angular-robot
Bot
added
area: docs
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the description of the browsers property in the unit-test builder schema to clarify the default behaviors of the Vitest and Karma runners. The feedback suggests formatting technical terms and configuration values with backticks to maintain consistency with other schema descriptions.
alan-agius4
requested changes
Oct 29, 2026
alan-agius4
left a comment
alan-agius4
left a comment
Collaborator
There was a problem hiding this comment.
Please squash the two commits (or update the fixup! commit message to include the backticks around `browsers`) so that the commit message lint check passes.
…tion The description states that tests run with jsdom when no browsers are set and gives 'ChromeHeadless' as the only example. The Vitest runner prefers happy-dom when it is installed, the Karma runner uses the browsers of its configuration, and the Vitest Playwright provider rejects 'chrome', so the example fails with the most common provider. Describe both runners and give an example for each.
MeAkib
force-pushed
the
docs/unit-test-browsers-description
branch
from
October 29, 2026 18:42
3ac3a71 to
db12eef
Compare
Contributor
Author
Done |
alan-agius4
approved these changes
Oct 29, 2026
alan-agius4
added
target: patch
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The description states that tests run with jsdom when no browsers are set and gives 'ChromeHeadless' as the only example. The Vitest runner prefers happy-dom when it is installed, the Karma runner uses the browsers of its configuration, and the Vitest Playwright provider rejects 'chrome', so the example fails with the most common provider. Describe both runners and give an example for each.