Repository navigation
fix(models): show verifying and loading while preparing an installed model - #1748
Open
kitlangton wants to merge 1 commit into
Open
kitlangton wants to merge 1 commit into
kitlangton wants to merge 1 commit into
Conversation
kitlangton
force-pushed
the
preparation-stage
branch
from
November 12, 2026 20:10
a6f2401 to
f2ecafc
Compare
kitlangton
force-pushed
the
preparation-stage
branch
from
November 12, 2026 21:43
f2ecafc to
53942b7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS and Windows, switching to a speech model that's already downloaded now says "Verifying model" and then "Loading model" instead of "Downloading 0%".
Linux already showed the real stage. Downloads look the same as before.
❌ Before
✅ After
📊 Proof: the picker with a model being prepared, before (what macOS and Windows always showed) and after (an installed model being checked).
These stills use the picker's fixture scene with its stage set by hand; the goldens don't change because the scenes set the stage themselves. New test
status_reports_the_worker_s_own_stagechecks an installed-only pick starts at Verifying, follows the worker to Loading, and a waiting download starts at Downloading.👀 Read:
status()inpreparation.rs: a waiting request has no task yet, so it reports the stage its worker will start in. The rest is routine.Found in a code audit (findings 08.5 and 06.3, the same defect) · no user reports
Checks run
scripts/check preparation macos_rune(macOS): 30 passedcargo clippy --locked --all-targets --features onnx-benchmark -- -D warnings(macOS): cleancheck-windows.ymlon this branch: passed, https://github.com/anomalyco/hex/actions/runs/43313107101